upgrading with stock_request_direction 16.0 causes error 'The method _button_immediate_install cannot be called on init or non loaded registries. Please use button_install instead.'

[risto42]

Module

stock_request_direction

Describe the bug

with a recent 16.0 OCA, I came across the following in odoo-server.log:

2025-05-23 14:29:05,582 216950 WARNING testODOO odoo.modules.loading: Transient module states were reset
2025-05-23 14:29:05,590 216950 ERROR testODOO odoo.modules.registry: Failed to load registry
Traceback (most recent call last):
   File "/opt/odoo/odoo/tools/convert.py", line 698, in _tag_root
     f(rec)
     ~^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 333, in _tag_function
     _eval_xml(self, rec, env)
     ~~~~~~~~~^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 204, in _eval_xml
     return odoo.api.call_kw(model, method_name, args, kwargs)
            ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/api.py", line 484, in call_kw
     result = _call_kw_multi(method, model, args, kwargs)
   File "/opt/odoo/odoo/api.py", line 469, in _call_kw_multi
     result = method(recs, *args, **kwargs)
   File "/opt/odoo/odoo/addons/base/models/res_config.py", line 613, in execute
     to_uninstall.button_immediate_uninstall()
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
   File "<decorator-gen-80>", line 2, in button_immediate_uninstall
   File "/opt/odoo/odoo/addons/base/models/ir_module.py", line 74, in check_and_log
     return method(self, *args, **kwargs)
   File "/opt/odoo/odoo/addons/base/models/ir_module.py", line 631, in button_immediate_uninstall
     return self._button_immediate_function(self.env.registry[self._name].button_uninstall)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/addons/base/models/ir_module.py", line 581, in _button_immediate_function
     raise UserError(_('The method _button_immediate_install cannot be called on init or non loaded registries. Please use button_install instead.'))
odoo.exceptions.UserError: La method _button_immediate_install ne peut pas être appelée sur des registres init ou non chargés. Veuillez utiliser button_install à la place.

The above exception was the direct cause of the following exception:
Traceback (most recent call last):
   File "/opt/odoo/odoo/modules/registry.py", line 87, in new
     odoo.modules.load_modules(registry, force_demo, status, update_module)
     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/modules/loading.py", line 489, in load_modules
     processed_modules += load_marked_modules(cr, graph,
                          ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
         ['installed', 'to upgrade', 'to remove'],
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         force, status, report, loaded_modules, update_module, models_to_check)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/modules/loading.py", line 374, in load_marked_modules
     loaded, processed = load_module_graph(
                         ~~~~~~~~~~~~~~~~~^
         cr, graph, progressdict, report=report, skip_modules=loaded_modules,
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         perform_checks=perform_checks, models_to_check=models_to_check
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     )
     ^
   File "/opt/odoo/odoo/modules/loading.py", line 233, in load_module_graph
     load_data(cr, idref, mode, kind='data', package=package)
     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/modules/loading.py", line 73, in load_data
     tools.convert_file(cr, package.name, filename, idref, mode, noupdate, kind)
     ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 763, in convert_file
     convert_xml_import(cr, module, fp, idref, mode, noupdate)
     ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 829, in convert_xml_import
     obj.parse(doc.getroot())
     ~~~~~~~~~^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 749, in parse
     self._tag_root(de)
     ~~~~~~~~~~~~~~^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 711, in _tag_root
     raise ParseError('while parsing %s:%s, somewhere inside\n%s' % (
     ...<3 lines>...
     )) from e
odoo.tools.convert.ParseError: while parsing /opt/odoo/OCA/stock_request_direction/views/res_config_settings.xml:7, somewhere inside
<function model="res.config.settings" name="execute">
         <value model="res.config.settings" search="[('id', '=', ref('stock_request_direction.res_config_settings_direction'))]"/>
     </function>
2025-05-23 14:29:05,594 216950 CRITICAL testODOO odoo.service.server: Failed to initialize database `testODOO`.
Traceback (most recent call last):
   File "/opt/odoo/odoo/tools/convert.py", line 698, in _tag_root
     f(rec)
     ~^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 333, in _tag_function
     _eval_xml(self, rec, env)
     ~~~~~~~~~^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 204, in _eval_xml
     return odoo.api.call_kw(model, method_name, args, kwargs)
            ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/api.py", line 484, in call_kw
     result = _call_kw_multi(method, model, args, kwargs)
   File "/opt/odoo/odoo/api.py", line 469, in _call_kw_multi
     result = method(recs, *args, **kwargs)
   File "/opt/odoo/odoo/addons/base/models/res_config.py", line 613, in execute
     to_uninstall.button_immediate_uninstall()
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
   File "<decorator-gen-80>", line 2, in button_immediate_uninstall
   File "/opt/odoo/odoo/addons/base/models/ir_module.py", line 74, in check_and_log
     return method(self, *args, **kwargs)
   File "/opt/odoo/odoo/addons/base/models/ir_module.py", line 631, in button_immediate_uninstall
     return self._button_immediate_function(self.env.registry[self._name].button_uninstall)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/addons/base/models/ir_module.py", line 581, in _button_immediate_function
     raise UserError(_('The method _button_immediate_install cannot be called on init or non loaded registries. Please use button_install instead.'))
odoo.exceptions.UserError: La method _button_immediate_install ne peut pas être appelée sur des registres init ou non chargés. Veuillez utiliser button_install à la place.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
   File "/opt/odoo/odoo/service/server.py", line 1327, in preload_registries
     registry = Registry.new(dbname, update_module=update_module)
   File "<decorator-gen-16>", line 2, in new
   File "/opt/odoo/odoo/tools/func.py", line 87, in locked
     return func(inst, *args, **kwargs)
   File "/opt/odoo/odoo/modules/registry.py", line 87, in new
     odoo.modules.load_modules(registry, force_demo, status, update_module)
     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/modules/loading.py", line 489, in load_modules
     processed_modules += load_marked_modules(cr, graph,
                          ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
         ['installed', 'to upgrade', 'to remove'],
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         force, status, report, loaded_modules, update_module, models_to_check)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/modules/loading.py", line 374, in load_marked_modules
     loaded, processed = load_module_graph(
                         ~~~~~~~~~~~~~~~~~^
         cr, graph, progressdict, report=report, skip_modules=loaded_modules,
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
         perform_checks=perform_checks, models_to_check=models_to_check
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     )
     ^
   File "/opt/odoo/odoo/modules/loading.py", line 233, in load_module_graph
     load_data(cr, idref, mode, kind='data', package=package)
     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/modules/loading.py", line 73, in load_data
     tools.convert_file(cr, package.name, filename, idref, mode, noupdate, kind)
     ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 763, in convert_file
     convert_xml_import(cr, module, fp, idref, mode, noupdate)
     ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 829, in convert_xml_import
     obj.parse(doc.getroot())
     ~~~~~~~~~^^^^^^^^^^^^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 749, in parse
     self._tag_root(de)
     ~~~~~~~~~~~~~~^^^^
   File "/opt/odoo/odoo/tools/convert.py", line 711, in _tag_root
     raise ParseError('while parsing %s:%s, somewhere inside\n%s' % (
     ...<3 lines>...
     )) from e
odoo.tools.convert.ParseError: while parsing /opt/odoo/OCA/stock_request_direction/views/res_config_settings.xml:7, somewhere inside
<function model="res.config.settings" name="execute">
         <value model="res.config.settings" search="[('id', '=', ref('stock_request_direction.res_config_settings_direction'))]"/>
     </function>

To Reproduce

Affected versions: 16.0.1.0.0
sudo -u odoo odoo-bin -c /etc/odoo/odoo.conf --no-http -u all --stop-after-init -d testODOO
(or -u stock_request_direction)

Expected behavior
A clean update should not raise errors of this sort

Additional context
using python 3.13

I was able to get over the error by the following patch:

richard@pn51-e1:/home/richard/src/OCA/stock-logistics-request/stock_request_direction$ git diff
diff --git a/stock_request_direction/views/res_config_settings.xml b/stock_request_direction/views/res_config_settings.xml
index c9d9148..6cbe82d 100644
--- a/stock_request_direction/views/res_config_settings.xml
+++ b/stock_request_direction/views/res_config_settings.xml
@@ -4,10 +4,4 @@
     <record model="res.config.settings" id="res_config_settings_direction">
         <field name="stock_request_allow_virtual_loc" eval="1" />
     </record>
-    <function model="res.config.settings" name="execute">
-        <value
-            model="res.config.settings"
-            search="[('id', '=', ref('stock_request_direction.res_config_settings_direction'))]"
-        />
-    </function>
 </odoo>

Unfortunately, I have no idea whether this is really an appropriate fix as I didn't directly install this module, it is certainly a dependency of something being used.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.