[MIG] stock_account_valuation_report: Migration to 18.0 #368

StefanRijnhart · 2025-02-05T15:26:33Z

Includes #378

StefanRijnhart · 2025-02-05T15:36:49Z

/ocabot migration stock_account_valuation_report

gdgellatly · 2025-03-06T02:20:47Z

stock_account_valuation_report/wizards/stock_valuation_history.py

+class StockValuationHistory(models.TransientModel):
+    _name = "stock.valuation.history"
+    _description = "Stock Valuation History"
+


Suggested change

_rec_name = "inventory_datetime"

I made same PR for 16.0 at #378

PIcked from #378, thanks.

gdgellatly · 2025-03-06T02:29:22Z

stock_account_valuation_report/models/product_product.py

        compute="_compute_inventory_value",
        search="_search_qty_discrepancy",
    )
-    valuation = fields.Selection(


Reviewed and understood reason for deletion. Field is now related on product.template to categ_id and directly accessible to product.

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-reporting-12.0/stock-logistics-reporting-12.0-stock_account_valuation_report Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-12-0/stock-logistics-reporting-12-0-stock_account_valuation_report/es_MX/

[IMP] stock_account_valuation_report: filter by discrepancies

Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_account_valuation_report Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_account_valuation_report/sl/

…e into account decimal precision

… filtering products with discrepancies also add a filter to see all discrepancies at once

…isplayed with AND conditions

Currently translated at 100.0% (37 of 37 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_account_valuation_report Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_account_valuation_report/it/

gdgellatly

I actually found these in the discrepancy module today, maybe we need it here too https://github.com/OCA/stock-logistics-reporting/pull/377/files#diff-d6055728635c3de730f384efe25ffbea9ac93cf0417f7337efb3b2a7fb88510e

stock_account_valuation_report/models/product_product.py

…rate precision

gdgellatly

LGTM, static review

AaronHForgeFlow

Functional review and ok with the changes in code

OCA-git-bot · 2025-04-02T11:16:31Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2025-04-02T11:16:31Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis

LGTM

rousseldenis · 2025-04-02T12:35:35Z

/ocabot merge nobump

OCA-git-bot · 2025-04-02T12:35:52Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-368-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2025-04-02T12:40:32Z

Congratulations, your PR was merged at f538c0c. Thanks a lot for contributing to OCA. ❤️

StefanRijnhart force-pushed the 18.0 branch 2 times, most recently from 067b468 to 54c5793 Compare February 5, 2025 15:31

OCA-git-bot added this to the 18.0 milestone Feb 5, 2025

OCA-git-bot mentioned this pull request Feb 5, 2025

Migration to version 18.0 #346

Open

18 tasks

gdgellatly reviewed Mar 6, 2025

View reviewed changes

JordiBForgeFlow and others added 23 commits March 6, 2025 09:27

[11.0][ADD] stock_account_valuation_report

a75fc1d

[MIG] stock_account_valuation_report: Migration to 12.0

ba41f8f

Added translation using Weblate (Spanish)

1776bcd

Added translation using Weblate (Spanish (Mexico))

2f54d15

Added translation using Weblate (Slovenian)

358b220

Added translation using Weblate (French)

e9cdd0d

[IMP] stock_account_valuation_report: black, isort, prettier

0bc005f

[13.0][MIG] stock_account_valuation_report

c86cd8d

[IMP] stock_account_valuation_report: filter by discrepancies

[IMP] stock_account_valuation_report: black, isort, prettier

5cd12de

[14.0][MIG]stock_account_valuation_report

93ced9d

[IMP] stock_account_valuation_report: black, isort, prettier

c89d77e

[15.0][MIG]stock_account_valuation_report

02e1771

Added translation using Weblate (German)

d96b469

[FIX] stock_account_valuation_report: exclude JE that are not posted

deeb0de

[MIG] stock_account_valuation_report: Migration to 16.0

85a37e1

Added translation using Weblate (Italian)

fa718ef

[FIX] stock_account_valuation_report: search discrepancies should tak…

e208e5d

…e into account decimal precision

[FIX] stock_account_valuation_report: consider archived products when…

3086690

… filtering products with discrepancies also add a filter to see all discrepancies at once

[IMP] stock_account_valuation_report: filters added are more useful d…

f4d7453

…isplayed with AND conditions

[IMP] stock_account_valuation_report: pre-commit auto fixes

0c36bf5

StefanRijnhart and others added 2 commits March 6, 2025 09:27

[MIG] stock_account_valuation_report: Migration to 18.0

73e4fce

[FIX] stock_account_valuation_report: Add rec_name field

a3cfda8

StefanRijnhart force-pushed the 18.0 branch from b949438 to a3cfda8 Compare March 6, 2025 08:27

gdgellatly requested changes Mar 6, 2025

View reviewed changes

stock_account_valuation_report/models/product_product.py Outdated Show resolved Hide resolved

stock_account_valuation_report/models/product_product.py Outdated Show resolved Hide resolved

[FIX] stock_account_valuation_report: check discrepancies with approp…

fc6a4a1

…rate precision

gdgellatly approved these changes Mar 6, 2025

View reviewed changes

IsabelAForgeFlow mentioned this pull request Mar 13, 2025

[18.0][MIG] stock_account_valuation_discrepancy_adjust #400

Open

AaronHForgeFlow approved these changes Apr 2, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 2, 2025

rousseldenis approved these changes Apr 2, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 2, 2025

OCA-git-bot merged commit a86b81c into OCA:18.0 Apr 2, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 2, 2025

Uh oh!

[MIG] stock_account_valuation_report: Migration to 18.0 #368

[MIG] stock_account_valuation_report: Migration to 18.0 #368

Uh oh!

Conversation

StefanRijnhart commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Feb 5, 2025

Uh oh!

gdgellatly Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

gdgellatly Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

gdgellatly Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

gdgellatly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 2, 2025

Uh oh!

OCA-git-bot commented Apr 2, 2025

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Apr 2, 2025

Uh oh!

OCA-git-bot commented Apr 2, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 2, 2025

Uh oh!

Uh oh!

StefanRijnhart commented Feb 5, 2025 •

edited

Loading

gdgellatly left a comment •

edited

Loading