[PORT][9.0] base multi image #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't lose commit history. You have to follow this procedure: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 |
|
The git commit message should contain |
atchuthan
force-pushed
the
9.0_base_multi_image
branch
from
4126fda to
2dfec51
Compare
|
@pedrobaeza changes done |
|
For information, relevant commit is 2dfec51 |
| @@ -131,12 +133,13 @@ | |||
| <field name="name">Multi images</field> | |||
| <field name="res_model">base_multi_image.image</field> | |||
| <field name="view_mode">kanban,tree,form</field> | |||
| <field name="help">Click to add multiple image</field> | |||
There was a problem hiding this comment.
Better to put "Click to add an image attached to an specific record."
|
Little remark, but overall 👍 (code review) |
atchuthan
force-pushed
the
9.0_base_multi_image
branch
from
2dfec51 to
bc3a87b
Compare
|
👍 |
|
@pedrobaeza Please add "needs review" label for this PR |
|
Cool thanks 👍 |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @yajo