[MIG] disable_openerp_online > disable_odoo_online #399
Conversation
|
👍 |
|
Please rename it to disable_odoo_online |
| @@ -20,7 +20,7 @@ | |||
| ############################################################################## | |||
| { | |||
| "name": "Remove odoo.com bindings", | |||
| "version": "8.0.1.1.0", | |||
| "version": "9.0.0.1.0", | |||
…. Update the version in the file __openerp__.py
|
@pedrobaeza thks for reviewing the pull request. I just fixed the source code taken into your comments. About the function "show_announcement_bar", it's still valid in v9 (you can find it in addons/mail/static/src/js/announcement.js). Please let me know if you have any other comments. |
| @@ -0,0 +1,9 @@ | |||
| odoo.define('disable_openerp_online.announcement', function (require) { | |||
There was a problem hiding this comment.
This should be odoo.define('disable_odoo_online.announcement', ...
There was a problem hiding this comment.
Thks for pointing this out. I will check other places also.
There was a problem hiding this comment.
The current file should be renamed to disable_odoo_online.js.
|
Excepting minor fixes, 👍 thank you! |
|
Thks @pedrobaeza @sebalix. I just committed the fixes for your comments. I also did the rename in po / pot files. I have 1 concern about the link to transifex (http://www.transifex.com/oca/OCA-server-tools-8-0/language/de) in po files, i don't know what should i do with it. And yes, if you have any other comments, please let me know... |
|
Some comments to finish:
|
…pdate_notification to new api
|
@pedrobaeza i just committed the fixes for
Have a nice day, |
|
👍 |
pedrobaeza
changed the title
Syncing from upstream OCA/server-tools (10.0)
No description provided.