[9.0] port - inactive_session_timeout #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pedrobaeza Currently i am testing the steps needed for contributing to OCA with this ported module. To get merged with 9.0, does the coverage increase is a must to have? |
|
Not really needed, but it should be great if you add tests for this module. This will ease future migrations, avoid regressions, and so on. |
|
Any news on this one? Do you need help? |
dvdhinesh
force-pushed
the
9.0-inactive_session_timeout
branch
from
9353e03 to
8455aba
Compare
|
@pedrobaeza Sorry for being late. Added a basic test for this module. |
|
@aristobulo-eezee Basic tests are added and the module is ported to V9. You are welcome to add the session validation tests, if you are interested. |
|
Sorry for the late reply. I recommend this one to be renamed as auth_session_timeout before merging. May I do it? |
|
👍 for auth_session_timeout |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting module "inactive_session_timeout" to 9.0