Skip to content

[18.0] [MIG] sale_company_currency: Migration to 18.0 #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 19 commits into from
May 12, 2025
Merged

[18.0] [MIG] sale_company_currency: Migration to 18.0 #3685

OCA-git-bot merged 19 commits into from
May 12, 2025

Conversation

@bizzappdev
Copy link
Contributor

@bizzappdev bizzappdev commented Apr 21, 2025

No description provided.

@bizzappdev bizzappdev marked this pull request as ready for review April 21, 2025 14:35
matteonext
matteonext approved these changes Apr 28, 2025
View reviewed changes
Copy link

@matteonext matteonext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok

@rousseldenis
Copy link
Contributor

rousseldenis commented Apr 29, 2025

/ocabot migration sale_company_currency

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 29, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 29, 2025
Open
rousseldenis
rousseldenis reviewed Apr 29, 2025
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bizzappdev Thanks for this. Maybe could you extract tests addition in a separate commit in order to be able to backport it ?

@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_company_currency-BAD branch from 566e176 to d13fd20 Compare April 29, 2025 08:57
@bizzappdev
Copy link
Contributor Author

bizzappdev commented Apr 29, 2025

@rousseldenis changes are done.

TDu
TDu approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks for migrating.

twalter-c2c
twalter-c2c approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@twalter-c2c twalter-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 1, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix
ivs-cetmix requested changes May 11, 2025
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bizzappdev , thank you for your contribution!
Please squash administrative commits (if any) with the previous commit for reducing commit noise as per the migration checklist requirements.

leemannd and others added 12 commits May 12, 2025 11:32
@leemannd @bizzappdev
base module & sales_team
7b67b37
@SimoRubi @bizzappdev
[FIX] README errors and manifest
1eb95b8
@pedrocs-exo @bizzappdev
Translated using Weblate (Portuguese)
5696d2d 
Currently translated at 83.3% (5 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/pt/
@danimv5 @bizzappdev
Translated using Weblate (Catalan)
1cdb189 
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/ca/
@danimv5 @bizzappdev
Translated using Weblate (Spanish)
c234447 
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/es/
@MatijaKrolo @bizzappdev
Translated using Weblate (Croatian)
e3e37d1 
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-10.0/sale-workflow-10.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_company_currency/hr/
@alexeirivera87 @bizzappdev
[IMP] sale_company_currency: black, isort, prettier
78d7142
@alexeirivera87 @bizzappdev
[MIG] sale_company_currency: Migration to 14.0
b4144ad
@francesco-ooops @bizzappdev
Translated using Weblate (Italian)
00f8ae1 
Currently translated at 33.3% (2 of 6 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_company_currency/it/
@bizzappdev
[IMP] sale_company_currency: pre-commit stuff
0f88cab
@bizzappdev
[MIG] sale_company_currency: Migration to 16.0
dc24ec9 
Fixed field name to position by
@weblate @bizzappdev
Update translation files
703f9b8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
adrianojprado and others added 7 commits May 12, 2025 11:32
@adrianojprado @bizzappdev
Translated using Weblate (Portuguese (Brazil))
1e5c182 
Currently translated at 83.3% (5 of 6 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/pt_BR/
@weblate @bizzappdev
Update translation files
bdc7175 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/
@mymage @bizzappdev
Translated using Weblate (Italian)
0ccccba 
Currently translated at 100.0% (6 of 6 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_company_currency
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_company_currency/it/
@dalonsofl @bizzappdev
[FIX] sale_company_currency: Changes on currency rate application
831f5d8
@bizzappdev
[IMP] sale_company_currency: pre-commit stuff
425ad0e
@bizzappdev
[MIG] sale_company_currency: Migration to 18.0
3bb2aed
@bizzappdev
[ADD] sale_company_currency: Added test cases.
8ab7a20
@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_company_currency-BAD branch from d13fd20 to 8ab7a20 Compare May 12, 2025 06:12
@bizzappdev
Copy link
Contributor Author

bizzappdev commented May 12, 2025

@ivs-cetmix squashing of the commits is done.

ivs-cetmix
ivs-cetmix approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bizzappdev thank you, LGTM!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 12, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3685-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 12, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 2fd656c into OCA:18.0 May 12, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 12, 2025

Congratulations, your PR was merged at ac2448f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

+3 more reviewers

@TDu TDu TDu approved these changes

@matteonext matteonext matteonext approved these changes

@twalter-c2c twalter-c2c twalter-c2c approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 migration needs review ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.