Skip to content

Conversation

@sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Aug 6, 2025

  • backport rma_repair

  • align repair creation with other operation-level actions via new action_create_repair field:

    • manual_on_confirm
    • manual_after_receipt
    • automatic_on_confirm
    • automatic_after_receipt
  • add can_be_repaired to control repair button visibility

  • extend confirm and receipt flows to support automatic repair creation

@sbejaoui sbejaoui force-pushed the 16.0-rma_repair-sbj branch 3 times, most recently from 4c40040 to 888f388 Compare August 6, 2025 17:30
@sbejaoui sbejaoui force-pushed the 16.0-rma_repair-sbj branch from 888f388 to 1191029 Compare August 6, 2025 17:54
@sbejaoui sbejaoui changed the title [16.0][ADD] backport rma_repair [16.0][IMP] BP rma_repair & align repair creation with other operation-level actions Aug 7, 2025
@sbejaoui sbejaoui force-pushed the 16.0-rma_repair-sbj branch 3 times, most recently from 601354c to 30ae0e7 Compare August 14, 2025 13:14
@sbejaoui sbejaoui force-pushed the 16.0-rma_repair-sbj branch from 30ae0e7 to 539ef4f Compare August 25, 2025 15:13
@sbejaoui sbejaoui force-pushed the 16.0-rma_repair-sbj branch 2 times, most recently from ad724ba to e1b505d Compare September 3, 2025 14:07
…receipt

- align repair creation with other operation-level actions via new `action_create_repair` field:
  - manual_on_confirm
  - manual_after_receipt
  - automatic_on_confirm
  - automatic_after_receipt

- add `can_be_repaired` to control repair button visibility
- extend confirm and receipt flows to support automatic repair creation
Copy link

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Could you change the backport commit message like [MIG] rma_repair: Backport from 17.0 to 16.0 ? Thanks

Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review + functional on runboat)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbejaoui
Copy link
Contributor Author

@pedrobaeza , a review here plz

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-467-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 196d7a8 into OCA:16.0 Sep 16, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b98a33e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants