Skip to content

Conversation

@dsolanki-initos
Copy link

@dsolanki-initos dsolanki-initos commented Jul 17, 2023

This module depends on attribute_set #141

Cédric Pigeon and others added 28 commits July 17, 2023 10:33
* Split computed methods in attribute.set.owner.mixin.
* Use assertRaisesRegex in tests to check for exact error message.
* Improve readability of event listner skip_if conditions.
add migration script : fields have been removed from v13 -> v14
@dsolanki-initos dsolanki-initos force-pushed the 16.0-mig-attribute_set_completeness branch 2 times, most recently from 9c91e98 to c66e3c2 Compare July 17, 2023 09:10
@simahawk
Copy link

simahawk commented Aug 9, 2023

/ocabot migration attribute_set_completeness

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 9, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 9, 2023
5 tasks
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the test dep as done on #142 ?

@@ -0,0 +1,27 @@
# Copyright 2022 Acsone SA
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this must be trashed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still to be trashed

@simahawk
Copy link

@dsolanki-initos ping

1 similar comment
@simahawk
Copy link

@dsolanki-initos ping

@rousseldenis
Copy link

/ocabot migration attribute_set_completeness

@hspl-priva
Copy link

hspl-priva commented Jan 19, 2024

LGTM @dsolanki-initos @pedrobaeza tested. seems ok. i think we can merge this.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions github-actions bot closed this Jun 23, 2024
@simahawk simahawk reopened this Mar 25, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants