-
-
Notifications
You must be signed in to change notification settings - Fork 155
[ADD] Rename users to user_ids in views #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a migration script to rename field references from "users" to "user_ids" in XML view files as part of migrating from version 180 to 190. The change appears to be part of a larger migration framework for Odoo modules.
- Adds a YAML configuration file for text replacement rules
- Updates migration script to include necessary imports
- Provides test data showing the expected transformation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/data_template/module_180/views/res_partner.xml | Test template showing original XML with "users" field reference |
| tests/data_result/module_180_190/views/res_partner.xml | Expected result showing "users" renamed to "user_ids" |
| odoo_module_migrate/migration_scripts/text_replaces/migrate_180_190/rename_users.yaml | Configuration file defining regex pattern for field name replacement |
| odoo_module_migrate/migration_scripts/migrate_180_190.py | Migration script with reorganized imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| import ast | ||
| import json |
Copilot
AI
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The imports ast and json are added at the top but appear to be duplicated with existing imports that were removed from elsewhere in the file. Verify these imports are actually used in the current codebase to avoid unused imports.
0948a9d to
4037d43
Compare
lef-adhoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vib-adhoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This PR has the |
4037d43 to
a57c920
Compare
a57c920 to
b8ebfbc
Compare
No description provided.