Skip to content

Conversation

@feg-adhoc
Copy link

No description provided.

Copilot AI review requested due to automatic review settings October 1, 2025 15:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a migration script to rename field references from "users" to "user_ids" in XML view files as part of migrating from version 180 to 190. The change appears to be part of a larger migration framework for Odoo modules.

  • Adds a YAML configuration file for text replacement rules
  • Updates migration script to include necessary imports
  • Provides test data showing the expected transformation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/data_template/module_180/views/res_partner.xml Test template showing original XML with "users" field reference
tests/data_result/module_180_190/views/res_partner.xml Expected result showing "users" renamed to "user_ids"
odoo_module_migrate/migration_scripts/text_replaces/migrate_180_190/rename_users.yaml Configuration file defining regex pattern for field name replacement
odoo_module_migrate/migration_scripts/migrate_180_190.py Migration script with reorganized imports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 5 to 4
import ast
import json
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports ast and json are added at the top but appear to be duplicated with existing imports that were removed from elsewhere in the file. Verify these imports are actually used in the current codebase to avoid unused imports.

Copilot uses AI. Check for mistakes.
@feg-adhoc feg-adhoc force-pushed the 19.0-t-57439-feg branch 3 times, most recently from 0948a9d to 4037d43 Compare October 7, 2025 14:25
Copy link
Contributor

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vib-adhoc vib-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants