[17.0][ADD] product_margin_report_landed_costs #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edescalona
force-pushed
the
17.0-add-product_margin_report_landed_costs
branch
4 times, most recently
from
fd3dd39 to
0c197cc
Compare
rrebollo
approved these changes
Sep 9, 2025
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Pure Code Review. LGTM!!! I do think functional review is critical on this kind of addons. Great contribution.
product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py
Outdated
Show resolved
Hide resolved
product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py
Outdated
Show resolved
Hide resolved
rrebollo
reviewed
Sep 9, 2025
product_margin_report_landed_costs/tests/test_product_margin_report_landed_costs.py
Show resolved
Hide resolved
|
I don't have extensive knowledge of stock valuation methodologies, but I am aware of the key differences between Anglo-Saxon and Continental accounting principles. Perhaps you could mention any prerequisites regarding those accounting standards in addon's documentation. |
…ated with the product to the Product Margins report.
edescalona
force-pushed
the
17.0-add-product_margin_report_landed_costs
branch
from
0c197cc to
6ed45cf
Compare
Author
|
ping @rrebollo |
|
Nice job @edescalona |
Author
|
ping @Christian-RB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
Add the landed costs associated with the product to the Product Margins report.