[17.0][MIG] sale_margin_delivered: Migration to 17.0 #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_margin_delivered
branch
3 times, most recently
from
effa715 to
01cccae
Compare
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_margin_delivered
branch
2 times, most recently
from
306b089 to
01cccae
Compare
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_margin_delivered
branch
from
01cccae to
e4e13bf
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
…l on delivery purchase price [UPD] README.rst [UPD] Update sale_margin_delivered.pot Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.
…not delivered qty (OCA#43) [FIX] sale_margin_delivered: Set % delivered percent to quantities ordered if the line has not delivered quantities [ADD] icon.png
…to compute delivered margin. Other module tests fails [UPD] README.rst
…yer instead of stock move
… has not quantity delivered TT26105
…e to this Odoo commit OCA/OCB@8ca10a8
We don't want to compute margin based on stock moves for non storable products. This specially true for services and kits. TT33499
…_margin_delivered_security
…ed_security TT44910
Currently translated at 100.0% (8 of 8 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/es/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (8 of 8 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/it/
… sent than ordered
Currently translated at 100.0% (11 of 11 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/it/
'price_reduce' is deprecated and removed into the next version. Compute the prirce_reduct from the price_subotal / product_uom_qty. We might be tempted to use the 'price_reduce_taxecl' field from the sale order line but this field is rounded by default to the monetary precision. As an additional benefit this change ensures the compatibility with the 'sale_triple_discount' addon. Indeed, when 'sale_triple_discount' is installed, the discount field is not used as an aggregation of all the applied discount. It's only use to store the first discount applied. Therefore, the field is not properly computed since it doesn't include the second and third discount.
Put all the new fields after the orginal margin fields from odoo. (prior to this change, the new fields were displayed among the margin fields from Odoo
…ion of 1 As it's done into the sale_margin addon from odoo
Currently translated at 100.0% (11 of 11 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_delivered Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_delivered/it/
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_margin_delivered
branch
from
e4e13bf to
e6a2d95
Compare
Contributor
Author
|
Hey @OCA/accounting-maintainers would be great if someone could have a look at this module. |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.