[18.0] FIX l10n_it_vat_registries: AttributeError: 'account.tax' object has no attribute '_l10n_it_get_tax_kind' #4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
The method has been removed from Odoo core in odoo/odoo@0f66a0c. Without this change, the following is raised: AttributeError: 'account.tax' object has no attribute '_l10n_it_get_tax_kind'
monen17
force-pushed
the
18.0-_l10n_it_get_tax_kind
branch
from
a060766 to
23fd5e5
Compare
tafaRU
approved these changes
Sep 26, 2025
monen17
requested changes
Sep 26, 2025
Comment on lines
+35
to
+38
| def _l10n_it_get_tax_kind(self): | ||
| if self.amount_type == "percent" and self.amount >= 0: | ||
| return "vat" | ||
| return None |
There was a problem hiding this comment.
Se c'è installato l10n_it_edi_withholding, l'imposta self poteva essere di tipo withholding o pension_fund, vedi l'override nel commit odoo/odoo@0f66a0c mentre ora il metodo restituirà sempre e solo vat o None, quindi in pratica
Visto che l10n_it_edi_withholding non è tra le dipendenze (e non credo vada aggiunto), penso sia meglio invece adattare i punti in cui viene chiamato _l10n_it_get_tax_kind per usare invece _l10n_it_filter_kind; cosa ne pensi?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4923