[18.0][MIG] l10n_it_financial_statements_report: Migration to 18.0 #4789

micheledic · 2025-06-03T06:48:15Z

No description provided.

micheledic · 2025-06-03T08:48:32Z

Ho introdotto con questa PR anche un metodo per il campo account_ids che sulla 18.0 restituisce "cannot be searchable" Issue OCA/account-financial-reporting#1306
Lo stesso l'ho proposto sul modulo originario, quindi nel caso venisse approvato tolgo e ripunto ad account_ids
OCA/account-financial-reporting#1327

eLBati

Grazie!

l10n_it_financial_statements_report/migrations/18.0.0.0.1/post-migrate.py

l10n_it_financial_statements_report/report/templates/financial_statements_report.xml

l10n_it_financial_statements_report/wizard/wizard_financial_statements_report.xml

l10n_it_financial_statements_report/models/account_group.py

micheledic · 2025-06-05T08:44:50Z

/ocabot migration

OCA-git-bot · 2025-06-05T08:44:53Z

Hi @micheledic. Your command failed:

Invalid options for command migration: .

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

micheledic · 2025-06-05T08:45:22Z

/ocabot migration l10n_it_financial_statements_report

OCA-git-bot · 2025-06-05T08:45:35Z

Sorry @micheledic you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

micheledic · 2025-06-05T08:46:16Z

@eLBati puoi tu ?

francesco-ooops · 2025-06-05T08:46:21Z

/ocabot migration l10n_it_financial_statements_report

monen17

Grazie della PR!
Ci sono diverse cose che non mi tornano sul segno dei gruppi di conti ma sono uguali a com'è in 16.0 quindi non è questo il momento di cambiarle, anche se qui il codice viene proprio aggiunto e non migrato perché è stato rimosso da df6d0e5.

Puoi schiacciare i commit come descritto in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate? Al momento diversi commit portati sono dei bot:

Potresti anche togliere [18.0] dal commit di migrazione? Al momento è

Ma i commit dovrebbero seguire https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message, quindi iniziare con un tag che in questo caso è [MIG].
Occhio anche al typo nel nome del modulo 😉
Ti consiglio di usare https://github.com/OCA/odoo-module-migrator che automatizza la creazione del commit e diversi passaggi per la migrazione.

l10n_it_financial_statements_report/migrations/18.0.0.0.1/post-migrate.py

l10n_it_financial_statements_report/models/account_group.py

l10n_it_financial_statements_report/report/financial_statements_report_xlsx.py

l10n_it_financial_statements_report/report/templates/financial_statements_report.xml

l10n_it_financial_statements_report/wizard/wizard_financial_statements_report.xml

micheledic · 2025-07-07T10:34:38Z

@monen17 ho squashato i commit del bot, fixato nome commit e alcuni attributi, aggiunto anche test-requirementst.txt per far dipendere dalla PR fix di account_financial_report (è corretto fare così giusto?
Per il css avevo già provato a usare
<t t-call="account_financial_report.html_container">

ma non viene proprio stampato il bundle asset backend.
Ho verificato proprio l'html generato che viene poi passato a wkhtml e c'è solo report asset bundle

micheledic · 2025-09-16T12:06:24Z

Sembra cha ancora non funzioni:

ho fatto 3 fatture, di cui 2 in valuta secondaria

il bilancio non restituisce il valore in valuta

Ciao,
http://oca-l10n-italy-18-0-pr4789-585833ad664f.runboat.odoo-community.org/odoo/customer-invoices/50/1
Ho dato nuovamente un rebuild, ho riprovato e me lo mostra correttamente. Ma viene mostrato selezionando la currency sul conto, come dal tuo primo test.
Peer com'è fatto nativamente il modulo account_financial_report , l'ending balance in currency viene sommato SOLO se sul conto c'è una currency selezionata come da description del campo :
https://github.com/OCA/account-financial-reporting/blob/4c53984534d148743e27c92f7b546d7fd77f4c98/account_financial_report/wizard/trial_balance_wizard.py#L57-62

financial_statements_report si basa su account_financial_report, i dati li prende dal wizard di financial_report e quindi ne eredita anche le logiche

VBNext · 2025-09-22T14:16:36Z

Confermo che se sul conto viene selezionata la valuta l'ending balance in currency viene sommato correttamente

C'è altro da controllare su questa PR?

micheledic · 2025-09-23T07:24:27Z

Confermo che se sul conto viene selezionata la valuta l'ending balance in currency viene sommato correttamente

C'è altro da controllare su questa PR?

Che io ricordi nulla, si può mergiare @OCA/local-italy-maintainers ?

mrcast

Confermo che impostando la valuta sul conto, poi viene riportato il valore in valuta Ending balance cur

andreampiovesana

nel manifest toglierei
"/tree/16.0/l10n_it_financial_statements_report",

Balance is too generic, Financial statements is what this module is producing

Currently translated at 100.0% (74 of 74 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_financial_statements_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_financial_statements_report/it/

Currently translated at 100.0% (70 of 70 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/

… update

Report XLSX: the syntax "if isinstance(value, int | float)" can be used on Python 3.10 and above versions. 16.0 code should be compatible with Python>=3.7 tho.

Currently translated at 100.0% (70 of 70 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/

…key'

Currently translated at 100.0% (71 of 71 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statements_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statements_report/it/

micheledic · 2025-09-26T13:21:32Z

nel manifest toglierei "/tree/16.0/l10n_it_financial_statements_report",

sono d'accordo.... tolto
fatto anche rebase(che non fa mai male!)

micheledic · 2025-09-26T13:24:44Z

@OCA/local-italy-maintainers test falliti sempre per #4923 , il resto ho cambiato solo manifest

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch 2 times, most recently from e1793e5 to 04d7fb0 Compare June 3, 2025 06:52

micheledic marked this pull request as draft June 3, 2025 07:10

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 04d7fb0 to 78694fe Compare June 3, 2025 08:35

micheledic marked this pull request as ready for review June 3, 2025 08:47

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch 3 times, most recently from addc917 to 2555cb4 Compare June 3, 2025 09:15

francesco-ooops added 18.0 migration labels Jun 4, 2025

eLBati reviewed Jun 4, 2025

View reviewed changes

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 2555cb4 to b33173d Compare June 4, 2025 10:30

micheledic requested review from eLBati and francesco-ooops June 4, 2025 13:07

odooNextev mentioned this pull request Jun 4, 2025

Migration to version 18.0 #4392

Open

41 tasks

OCA-git-bot added this to the 18.0 milestone Jun 5, 2025

Borruso mentioned this pull request Jun 13, 2025

PR aggiunte v18 DinamicheAziendali/l10n-italy#2

Open

8 tasks

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jun 13, 2025

[ADD] l10n_it_financial_statements_report: aggiunta PR OCA#4789

27e39b6

monen17 requested changes Jul 4, 2025

View reviewed changes

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch 2 times, most recently from 1bdeda0 to 39c908e Compare July 7, 2025 10:31

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 39c908e to 81ff7a5 Compare July 7, 2025 10:53

mrcast approved these changes Sep 23, 2025

View reviewed changes

andreampiovesana suggested changes Sep 26, 2025

View reviewed changes

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from 585833a to bb0b791 Compare September 26, 2025 13:18

SirTakobi and others added 21 commits September 26, 2025 15:19

[REF] l10n_it_account_balance_report: Rename

80701f2

Balance is too generic, Financial statements is what this module is producing

[IMP] l10n_it_financial_statements_report: pre-commit execution

38210e3

[MIG] l10n_it_financial_statements_report: Migration to 16.0

728ebec

[REF] l10n_it_financial_statements_report: Remove test output file

4bdb8e1

Updated from template

cb4b735

[REF] l10n_it_financial_statements_report: Update repo template

7be6044

[REF] l10n_it_financial_statements_report: Reformatted after template…

273145e

… update

Updated from template

b9022a8

[FIX] l10n_it_financial_statements_report: Prepayments are assets

84c1b8a

[FIX]l10n_it_financial_statements_report: Syntax compatibility

b648daf

Report XLSX: the syntax "if isinstance(value, int | float)" can be used on Python 3.10 and above versions. 16.0 code should be compatible with Python>=3.7 tho.

FIX l10n_it_financial_statements_report: use landscape format for PDF

e2fab75

[FIX] l10n_it_financial_statements_report: fix for KeyError 'grouped_…

cba2cb9

…key'

[IMP] l10n_it_financial_statements_report: add company header

29bdb36

[IMP] l10n_it_financial_statements_report: pre-commit stuff

f5cf1ea

[MIG] l10n_it_financial_statements_report: Migration to 18.0

75a46cc

micheledic force-pushed the 18.0_mig_l10n_it_financial_statements_report branch from bb0b791 to 75a46cc Compare September 26, 2025 13:19

Uh oh!

[18.0][MIG] l10n_it_financial_statements_report: Migration to 18.0 #4789

Are you sure you want to change the base?

[18.0][MIG] l10n_it_financial_statements_report: Migration to 18.0 #4789

Uh oh!

Conversation

micheledic commented Jun 3, 2025

Uh oh!

micheledic commented Jun 3, 2025

Uh oh!

eLBati left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

micheledic commented Jun 5, 2025

Uh oh!

OCA-git-bot commented Jun 5, 2025

Uh oh!

micheledic commented Jun 5, 2025

Uh oh!

OCA-git-bot commented Jun 5, 2025

Uh oh!

micheledic commented Jun 5, 2025

Uh oh!

francesco-ooops commented Jun 5, 2025

Uh oh!

monen17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

micheledic commented Jul 7, 2025

Uh oh!

micheledic commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VBNext commented Sep 22, 2025

Uh oh!

micheledic commented Sep 23, 2025

Uh oh!

mrcast left a comment

Choose a reason for hiding this comment

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

micheledic commented Sep 26, 2025

Uh oh!

micheledic commented Sep 26, 2025

Uh oh!

Uh oh!

micheledic commented Sep 16, 2025 •

edited

Loading