Skip to content

[18.0][ADD]l10n_it_edi_related_document: l10n_it_edi extension for multiple related document type management #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

[18.0][ADD]l10n_it_edi_related_document: l10n_it_edi extension for multiple related document type management #4749

merged 2 commits into from
Sep 5, 2025

Conversation

matteonext
Copy link
Contributor

@matteonext matteonext commented May 8, 2025 •
edited
Loading

Allows import and export of multiple related document types, similar to l10n_it_fatturapa. Also removes the read-only restriction on lineRef. Removes the invoice_line reference from the related document type model, as it is only needed in the report.
Hides l10n_it_edi fields from the invoice view, but keeps them available for import.

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch from 26f0293 to bdcf23f Compare May 8, 2025 12:57
@matteonext matteonext changed the title [18.0][ADD]l10n_it_edi_related_document_type [18.0][ADD]l10n_it_edi_related_document_type: l10n_it_edi extension for multiple related document type management May 8, 2025
@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch 2 times, most recently from 6a0954b to d4c7a72 Compare May 8, 2025 13:14
monen17
monen17 requested changes May 9, 2025
View reviewed changes
Copy link
Contributor

@monen17 monen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Come dicevo stamattina in chiamata, secondo me anche questo si potrebbe includere in l10n_it_edi_extension (#4411) perché non vedo grandi differenze tra questa funzionalità e la visualizzazione dell'anteprima, o le altre funzionalità già incluse in quel modulo.

Anche lasciarlo in un modulo a sé ha senso, ma allora potevamo farlo anche per le altre funzionalità 🤷

Quindi per me vanno bene entrambe le soluzioni.

Non ho visto script di migrazione, quindi se uno migra da 16.0 perde tutti i documenti collegati alle fatture?

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch 2 times, most recently from d691ce1 to 0e22e76 Compare May 12, 2025 14:56
@matteonext
Copy link
Contributor Author

@monen17 Grazie mille per la review! Seguendo le indicazioni e commenti nella task del portale Odoo Italia ho scelto di farlo in un modulo separato. Non ci sarebbero comunque problemi ad aggiungere le funzionalità in l10n_it_edi_extension.
Al momento non ho aggiunto lo script di migrazione, lo posso aggiungere nei prossimi giorni per evitare di perdere i documenti collegati alle fatture.

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch from ba46619 to 6cf4ab5 Compare May 15, 2025 11:41
@matteonext matteonext requested a review from monen17 May 15, 2025 11:45
monen17
monen17 requested changes May 19, 2025
View reviewed changes
Copy link
Contributor

@monen17 monen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie delle modifiche!
Oltre ai punti ancora aperti qui sotto, manca ancora lo script di migrazione.

Ah e ricorda di modificare anche il messaggio del commit visto che il nome del modulo è cambiato.

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch 2 times, most recently from 190129c to fbc1827 Compare May 23, 2025 12:05
@matteonext
Copy link
Contributor Author

@monen17 Grazie anche per questa review! Ho aggiornato la pr per gestire il collegamento tra le righe di fattura e i documenti collegati, sia in import xml che nel create.
Ho aggiunto anche lo script di migrazione.

@matteonext matteonext requested a review from monen17 May 23, 2025 15:22
monen17
monen17 requested changes May 25, 2025
View reviewed changes
Copy link
Contributor

@monen17 monen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho fatto solo revisione del codice e secondo me manca solo più qualche piccola modifica; non ho modo di verificare la migrazione ma a occhio mi sembra ok.

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch from fbc1827 to 0a90443 Compare May 28, 2025 14:35
@matteonext matteonext requested a review from monen17 May 29, 2025 06:34
@matteonext matteonext changed the title [18.0][ADD]l10n_it_edi_related_document_type: l10n_it_edi extension for multiple related document type management [18.0][ADD]l10n_it_edi_related_document: l10n_it_edi extension for multiple related document type management Jun 5, 2025
@odooNextev odooNextev mentioned this pull request Jun 5, 2025
Open
41 tasks
@francesco-ooops
Copy link
Contributor

/ocabot migration l10n_it_edi_related_document

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jun 5, 2025
@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch from 2e03825 to 5a2c2b4 Compare June 23, 2025 14:19
@odooNextev
Copy link
Contributor

@monen17 puoi re-revisionare?

Borruso
Borruso suggested changes Jul 11, 2025
View reviewed changes
l10n_it_edi_related_document/migrations/18.0.1.0.0/post-migration.py Outdated
)


@openupgrade.migrate()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

togliere decoratore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borruso puoi aggiornare la review visto che è stata sistemata la migrazione?

monen17
monen17 approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@monen17 monen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie delle modifiche!
Ho fatto revisione del codice e per me è ok.

Non ho guardato la migrazione, e come ha detto stamattina @eLBati in chiamata potrebbe essere che non venga proprio eseguita essendo questo un nuovo modulo.
Stamattina però abbiamo anche detto che non è necessario migrare i dati per procedere al merge quindi ok così.

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch from b084dfb to 1f8ff2e Compare July 11, 2025 14:50
@Borruso Borruso mentioned this pull request Jul 14, 2025
Open
8 tasks
Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 14, 2025
@Borruso
[ADD] l10n_it_edi_related_document: aggiunta PR OCA#4749
853627e
@matteonext
Copy link
Contributor Author

Ho testato le migrazioni in locale e cosi vengono applicate correttamente all'installazione del modulo

@matteonext matteonext force-pushed the 18.0-add-l10n_it_edi_document branch from 79bd60b to 58529a4 Compare July 16, 2025 14:59
Borruso
Borruso approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@Borruso Borruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU
Copy link
Member

tafaRU commented Sep 5, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-4749-by-tafaRU-bump-nobump, awaiting test results.

@OCA OCA deleted a comment from OCA-git-bot Sep 5, 2025
@OCA OCA deleted a comment from OCA-git-bot Sep 5, 2025
@OCA-git-bot OCA-git-bot merged commit f03e5f6 into OCA:18.0 Sep 5, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a51ea89. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati left review comments

@monen17 monen17 monen17 approved these changes

+2 more reviewers

@odooNextev odooNextev odooNextev left review comments

@Borruso Borruso Borruso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved merged 🎉 needs functional review
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
8 participants
@matteonext @francesco-ooops @odooNextev @tafaRU @OCA-git-bot @eLBati @monen17 @Borruso