Skip to content

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Feb 17, 2025

This module extends contract sale generation by merging contract lines into an existing sale order within the same commitment (delivery) date.

cc https://github.com/APSL 166288

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@ppyczko ppyczko force-pushed the 15.0-add-contract_sale_generation_merge branch from fc0c764 to cd434cc Compare February 17, 2025 10:20
@ppyczko ppyczko marked this pull request as ready for review February 17, 2025 10:27
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code reivew and tested in runboat

@rousseldenis rousseldenis added this to the 15.0 milestone Feb 18, 2025
@ppyczko ppyczko force-pushed the 15.0-add-contract_sale_generation_merge branch from cd434cc to b21ed36 Compare February 18, 2025 10:05
Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised code and runboat, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

@ppyczko
Copy link
Author

ppyczko commented Apr 16, 2025

Hi @rousseldenis @pedrobaeza, can you please review and check if this is ready to be merged? Thank you!

@ppyczko ppyczko force-pushed the 15.0-add-contract_sale_generation_merge branch 3 times, most recently from 6dfec64 to 282d3b9 Compare May 12, 2025 15:21
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 14, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 21, 2025
@ppyczko ppyczko force-pushed the 15.0-add-contract_sale_generation_merge branch from 282d3b9 to b145f65 Compare September 22, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants