-
-
Notifications
You must be signed in to change notification settings - Fork 567
[15.0][ADD] contract_sale_generation_merge: New module contract_sale_generation_merge #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 15.0
Are you sure you want to change the base?
Conversation
fc0c764
to
cd434cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code reivew and tested in runboat
cd434cc
to
b21ed36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised code and runboat, LGTM
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat and code review
Hi @rousseldenis @pedrobaeza, can you please review and check if this is ready to be merged? Thank you! |
6dfec64
to
282d3b9
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
282d3b9
to
b145f65
Compare
This module extends contract sale generation by merging contract lines into an existing sale order within the same commitment (delivery) date.
cc https://github.com/APSL 166288
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review