[IMP] account_fiscal_year_closing: Avoid memory error #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mapped` loads a lot of data in the cache, so when we are closing a fiscal year with a lot of lines the following exception might be raised:
```
File "/opt/odoo/custom/oca/account-closing/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 291, in button_calculate
res = self.calculate()
File "/opt/odoo/custom/oca/account-closing/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 275, in calculate
move, data = config.moves_create()
File "/opt/odoo/custom/oca/account-closing/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 509, in moves_create
move_lines = self._mapping_move_lines_get()
File "/opt/odoo/custom/oca/account-closing/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 456, in _mapping_move_lines_get
balance, move_line = account_map.move_line_prepare(account, lines)
File "/opt/odoo/custom/oca/account-closing/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 593, in move_line_prepare
balance = sum(account_lines.mapped("debit")) - sum(
File "/usr/lib/python3/dist-packages/odoo/models.py", line 5292, in mapped
recs = recs._fields[name].mapped(recs)
File "/usr/lib/python3/dist-packages/odoo/fields.py", line 1109, in mapped
self.__get__(first(remaining), type(remaining))
File "/usr/lib/python3/dist-packages/odoo/fields.py", line 1019, in __get__
recs._fetch_field(self)
File "/usr/lib/python3/dist-packages/odoo/models.py", line 3078, in _fetch_field
self._read(fnames)
File "/usr/lib/python3/dist-packages/odoo/models.py", line 3175, in _read
self.env.cache.update(fetched, field, values)
File "/usr/lib/python3/dist-packages/odoo/api.py", line 817, in update
field_cache.update(zip(records._ids, values))
Exception
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/odoo/http.py", line 652, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/usr/lib/python3/dist-packages/odoo/http.py", line 317, in _handle_exception
raise exception.with_traceback(None) from new_cause
MemoryError
```
|
@grindtildeath fw-porting of #346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mappedloads a lot of data in the cache, so when we are closing a fiscal year with a lot of lines the following exception might be raised: