Skip to content

[18.0] [MIG] account_fiscal_year_closing: Migration to 18.0 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: 18.0
Choose a base branch
from
Open

[18.0] [MIG] account_fiscal_year_closing: Migration to 18.0 #316

wants to merge 30 commits into from

Conversation

Borruso
Copy link

@Borruso Borruso commented Jan 24, 2025 •
edited
Loading

issue: #306

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 25, 2025
@matteonext
Copy link

Hi @Borruso Could you please rebase so I can try this pr? Thanks

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 15, 2025
antespi and others added 26 commits June 20, 2025 13:10
@antespi @Borruso
[ADD] account_fiscalyear_closing: Generic engine for closing operations
f0f3cd4
@pedrobaeza @Borruso
[FIX+IMP] account_fiscal_year_closing
3356b47 
* Included template mechanism
* Remove unused files
* Fix behaviors
* Some refactoring
* Complete features
@JordiBForgeFlow @Borruso
migrate account_fiscal_year_closing to 10.0
72bbce3
@sergiocorato @Borruso
[12.0][PORT] account fiscal year closing
9b9e256
@alexey-pelykh @Borruso
[FIX] account_fiscal_year_closing: tests should not use fixed dates
2bae4bc
@eLBati @Borruso
Translated using Weblate (Italian)
101aadd 
Currently translated at 66.6% (76 of 114 strings)

Translation: account-closing-12.0/account-closing-12.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_fiscal_year_closing/it/
@eLBati @Borruso
IMP account_fiscal_year_closing adding multi company rule for account…
1225b49 
….fiscalyear.closing.template
@marcelsavegnago @Borruso
Added translation using Weblate (Portuguese (Brazil))
1898928
@SimoRubi @Borruso
[IMP] account_fiscal_year_closing: black, isort, prettier
904b9b6
@SimoRubi @Borruso
[MIG] account_fiscal_year_closing: Migration to 14.0
7c49409 
Fixed warnings:
Field account.fiscalyear.closing.closing_template_id: unknown parameter 'oldname', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
Field account.move.fyc_id: unknown parameter 'delete', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it
The model account.fiscalyear.closing.config has no _description
The model account.fiscalyear.closing.mapping has no _description
The model account.fiscalyear.closing.type has no _description
The model account.fiscalyear.closing.template has no _description
The model account.fiscalyear.closing.config.template has no _description
The model account.fiscalyear.closing.mapping.template has no _description
The model account.fiscalyear.closing.type.template has no _description
The model account.fiscalyear.closing.unbalanced.move has no access rules
The model account.fiscalyear.closing.unbalanced.move.line has no access rules
odoo.addons.base.models.ir_ui_view: Search tag requires at least one field element
The method '_company_default_get' on res.company is deprecated and shouldn't be used anymore
DeprecationWarning: RedirectWarning method 'post()' is a deprecated alias to 'action_post()' or _post()
@SimoRubi @Borruso
[IMP] account_fiscal_year_closing: Restore onchange on closing's temp…
c2b11e6 
…late
@SimoRubi @Borruso
[IMP] account_fiscal_year_closing: Add date field to unbalanced move …
6f640f4 
…line.

Otherwise the following might happen:
  File "/path/to/odoo/addons/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 328, in button_calculate
    res = self.calculate()
  File "/path/to/odoo/addons/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 315, in calculate
    return self._show_unbalanced_move_wizard(data)
  File "/path/to/odoo/addons/account_fiscal_year_closing/models/account_fiscalyear_closing.py", line 295, in _show_unbalanced_move_wizard
    wizard = self.env["account.fiscalyear.closing.unbalanced.move"].create(data)
[...]
ValueError: Invalid field 'date' on model 'account.fiscalyear.closing.unbalanced.move.line'
@Borruso
[FIX][account_fiscal_year_closing] fix create and write
f7c54dc
@francesco-ooops @Borruso
Translated using Weblate (Italian)
d8f27cb 
Currently translated at 92.1% (105 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@alessandrocamilli @Borruso
Translated using Weblate (Italian)
f63901c 
Currently translated at 92.1% (105 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@primes2h @Borruso
Translated using Weblate (Italian)
224571c 
Currently translated at 92.9% (106 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@francesco-ooops @Borruso
Translated using Weblate (Italian)
359ffe7 
Currently translated at 100.0% (114 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@alessandrocamilli @Borruso
Translated using Weblate (Italian)
138480c 
Currently translated at 100.0% (114 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@francesco-ooops @Borruso
Translated using Weblate (Italian)
510744e 
Currently translated at 100.0% (114 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@douglascstd @Borruso
Translated using Weblate (Portuguese (Brazil))
a45f4ef 
Currently translated at 95.6% (109 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/pt_BR/
@michelerusti @Borruso
[14.0][FIX] - account_fiscal_year_closing - closing procedure compute…
eb38ff2 
…s canceled entries in closing
@mymage @Borruso
Translated using Weblate (Italian)
f60aa55 
Currently translated at 100.0% (114 of 114 strings)

Translation: account-closing-14.0/account-closing-14.0-account_fiscal_year_closing
Translate-URL: https://translation.odoo-community.org/projects/account-closing-14-0/account-closing-14-0-account_fiscal_year_closing/it/
@Borruso
[MIG] account_fiscal_year_closing: Migration to 16.0
047aeab
@Borruso
[FIX] account_fiscal_year_closing: move line created with correct cur…
4b92cea 
…rency
@Borruso
[FIX] account_fiscal_year_closing: create/write
45a5835 
When creating from scratch, Mapping is used as an Array instead of simple id (due to many in another many).
When coming from a template, id is used
To take into account this particularity, check the type before taking the id of the array.
@pedrobaeza @Borruso
[REF] account_fiscal_year_closing: Debrand module
dbcb3ed 
Although we originally developped the module, we figured out soon
that this approach is not correct, so we prefer to not appearing
in the credits.
@Borruso Borruso force-pushed the 18.0-mig-account_fiscal_year_closing branch from 96d0326 to 1e448cd Compare June 20, 2025 11:11
@eLBati eLBati mentioned this pull request Jul 8, 2025
Open
@tafaRU
Copy link
Member

tafaRU commented Jul 11, 2025

/ocabot migration account_fiscal_year_closing

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 11, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 11, 2025
Open
6 tasks
@eLBati
Copy link
Member

eLBati commented Jul 21, 2025

@Borruso fixing interface with Borruso#2

@eLBati eLBati mentioned this pull request Jul 21, 2025
Merged
MaurizioConte
MaurizioConte approved these changes Jul 31, 2025
View reviewed changes
Copy link

@MaurizioConte MaurizioConte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test su versione 18.0 effettuati con successo.

@Borruso Borruso force-pushed the 18.0-mig-account_fiscal_year_closing branch from e0c0435 to 97d57ba Compare August 1, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MaurizioConte MaurizioConte MaurizioConte approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.