Skip to content

Dummy 3.2 #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ralfhandl wants to merge 11 commits into from
Closed

Dummy 3.2 #4714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3a0fb3d
Use full schema (schema-base.yaml) for coverage
handrews Jun 13, 2025
0fadf2e
Do not expect coverage of unreachable schema
handrews Jun 13, 2025
f66d94c
Fix spelling
handrews Jun 13, 2025
d986f88
Fix coverage calculation
handrews Jun 13, 2025
20eec3a
Remove stray commented-out line.
handrews Jun 13, 2025
0c75419
Update scripts/schema-test-coverage.mjs
handrews Jun 13, 2025
b862c2e
Merge pull request #4701 from handrews/cov-main
ralfhandl Jun 13, 2025
3b6551c
Fix typos
handrews Jun 13, 2025
1873c23
Merge pull request #4708 from handrews/fixit
ralfhandl Jun 13, 2025
ea3dd41
Set exit code only if base branch is not dev
ralfhandl Jun 14, 2025
7ed3b18
Merge branch 'main-base-branch-for-schema-tests' into dummy-3.2
ralfhandl Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/schema-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ name: schema-test
#

# run this on push to any branch and creation of pull-requests
on:
push: {}
on:
pull_request: {}
workflow_dispatch: {}

Expand All @@ -33,3 +32,5 @@ jobs:

- name: Run tests
run: npm run test
env:
BASE: ${{ github.event.pull_request.base.ref }}
4 changes: 1 addition & 3 deletions scripts/schema-test-coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@

[[ ! -e src/schemas ]] && exit 0

branch=$(git branch --show-current)

echo
echo "Schema Test Coverage"
echo

node scripts/schema-test-coverage.mjs src/schemas/validation/schema-base.yaml tests/schema/pass
rc=$?

[[ "$branch" == "dev" ]] || exit $rc
[[ "$BASE" == "dev" ]] || exit $rc