Skip to content

Conversation

@tfesenko
Copy link
Contributor

The runtime expression must be quoted as it starts with a '{' - an indicator character, otherwise it's invalid YAML.

I also added the 'openapi' and 'info' properties because they are required and, thus, the spec file is invalid without them.

The runtime expression [must be quoted](http://www.yaml.org/spec/1.2/spec.html#id2788859) as it starts with a '{' - an [indicator character](http://www.yaml.org/spec/1.2/spec.html#c-indicator)

Also added 'openapi' and 'info' properties because they are required and, thus, the spec file is invalid without them.
tfesenko added a commit to RepreZen/KaiZen-OpenAPI-Editor that referenced this pull request Jun 20, 2017
@MikeRalphson
Copy link
Member

Was this example ever intended to be complete / self-contained? It also has a missing definition of #/components/schemas/UserLogData

@RobDolinMS
Copy link
Contributor

#TDC: @tfesenko Thank you for submitting this PR. Would you please update per @MikeRalphson's comment so this is a complete example.

You may want to align with what @whitlockjc is drafting for Issue #1245

@whitlockjc
Copy link
Member

@tfesenko If you would like to get this addressed ASAP and not wait for #1245, I would just make the following changes to your PR as it will align with our plans:

  1. Replaces lines 1-4 with # ... (this will be our way to indicate "omitted for brevity")
  2. Resolve the $ref on line 51:
    a. Add # ... as the last line of the document
    b. Replace $ref with an inline schema

I guess 2.a could be documented in #1245 but for now, being explicit might not be a bad thing.

@RobDolinMS
Copy link
Contributor

ACTION: @tedepstein to reach-out to @tfesenko when she's back (likely Mon, 7/10)

@RobDolinMS RobDolinMS added this to the Ancillary milestone Jul 7, 2017
Replace lines 1-4 with # ... (this will be our way to indicate "omitted for brevity")
Resolve the $ref on line 51 by replace $ref with an inline schema
@tfesenko
Copy link
Contributor Author

tfesenko commented Jul 9, 2017

@whitlockjc , I addressed your suggestions in commit ccf0169. Can you please have a look? Thanks!

@whitlockjc
Copy link
Member

:shipit:

@whitlockjc
Copy link
Member

Since this is a non-spec change, we should be able to branch/merge into master instead of a release-specific branch. I will have to merge this manually.

whitlockjc added a commit that referenced this pull request Aug 18, 2017
@whitlockjc
Copy link
Member

Merged manually 542fc44

@whitlockjc whitlockjc closed this Aug 18, 2017
@whitlockjc
Copy link
Member

Weird, it didn't keep your commits but the commit message clearly points to your commit.

@whitlockjc
Copy link
Member

@tfesenko I apologize the merged commit didn't retain your authorship of the two commits. I did it this way to avoid asking you to delete this PR and recreate a new one from master. Next time, I'll just ask you to create a new PR so your details in up in the commit log. I apologize.

NebulaNarrator added a commit to NebulaNarrator/rofessional that referenced this pull request Jul 30, 2025
ImagineIsle added a commit to ImagineIsle/CNV that referenced this pull request Aug 14, 2025
EzraVoss added a commit to EzraVoss/EzraVoss that referenced this pull request Sep 25, 2025
donnanright added a commit to donnanright/Bytecoin-Faucet that referenced this pull request Sep 25, 2025
novikserge added a commit to novikserge/bolton that referenced this pull request Oct 3, 2025
mytopope added a commit to mytopope/Portuguese that referenced this pull request Oct 13, 2025
scarletcoffee added a commit to scarletcoffee/GT811 that referenced this pull request Dec 5, 2025
aoguase added a commit to aoguase/pancake that referenced this pull request Dec 14, 2025
BeautifulCodeva added a commit to BeautifulCodeva/machineway that referenced this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants