-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Fix callback-example.yaml #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The runtime expression [must be quoted](http://www.yaml.org/spec/1.2/spec.html#id2788859) as it starts with a '{' - an [indicator character](http://www.yaml.org/spec/1.2/spec.html#c-indicator) Also added 'openapi' and 'info' properties because they are required and, thus, the spec file is invalid without them.
|
Was this example ever intended to be complete / self-contained? It also has a missing definition of |
|
#TDC: @tfesenko Thank you for submitting this PR. Would you please update per @MikeRalphson's comment so this is a complete example. You may want to align with what @whitlockjc is drafting for Issue #1245 |
|
@tfesenko If you would like to get this addressed ASAP and not wait for #1245, I would just make the following changes to your PR as it will align with our plans:
I guess 2.a could be documented in #1245 but for now, being explicit might not be a bad thing. |
|
ACTION: @tedepstein to reach-out to @tfesenko when she's back (likely Mon, 7/10) |
Replace lines 1-4 with # ... (this will be our way to indicate "omitted for brevity") Resolve the $ref on line 51 by replace $ref with an inline schema
|
@whitlockjc , I addressed your suggestions in commit ccf0169. Can you please have a look? Thanks! |
|
|
|
Since this is a non-spec change, we should be able to branch/merge into |
|
Merged manually 542fc44 |
|
Weird, it didn't keep your commits but the commit message clearly points to your commit. |
|
@tfesenko I apologize the merged commit didn't retain your authorship of the two commits. I did it this way to avoid asking you to delete this PR and recreate a new one from |
The runtime expression must be quoted as it starts with a '{' - an indicator character, otherwise it's invalid YAML.
I also added the 'openapi' and 'info' properties because they are required and, thus, the spec file is invalid without them.