-
Notifications
You must be signed in to change notification settings - Fork 57
Clarity on referencing Components Parameters #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll get to this tomorrow or at the latest Friday. |
@frankkilcommins Sorry for the delay, I had to go back and reconsider this as I missed some things with my original feedback. For some reason, I had thought this was resolving names from the Components Object (like Security Requirement Objects resolve Security Scheme names from Components). But now I see that this is a Reference Object, and AFAICT it's the only use of a Reference Object in the spec. So I read through that section, and I'm guessing one reason it's a Reference Object is to allow referencing parameter definitions that go with the target operation, which would require referencing external documents. Then I thought... since this is the only use of a Reference Object, and everything else is using some form of runtime expression (sometimes with a JSON Pointer), why not get rid of this Reference Object and use a runtime expression instead? With whatever modification you need to do the value override thing. You would still have JSON Schema references, but they are slightly different anyway. I apologize for throwing a new idea in at the last minute here, but given the work we've done to avoid using |
@handrews I think it's achievable to move in this direction and not have any specification specific Reference Object situations. It means I'll have to re-write some code I build for parsing but such is life 😛 This section will also need an update (it's not correct in it's current state anyway IMO with the exception of a JSON Schema reference but that's not mentioned either). Instead of the current situation of:
We could have something like (with the appropriate verbiage that the parameter
|
@frankkilcommins that looks great to me! (although you either need to make both of those array entries or give a property name to the |
…ace with expression based referencing
@handrews finally got around to making this change........no more Reference Object 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great - my only suggestion is maybe call it a "Parameter Re-Use Object" or something of that sort to avoid it sounding too much like "Reference Object"? But if you prefer the "Parameter Reference Object" name I'd happily approve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
…170) * chore: suggest multilevel parameters (#155) * chore: suggest multilevel parameters * Update versions/1.0.0.md Co-authored-by: Frank Kilcommins <[email protected]> * Update examples/1.0.0/ExtendedParametersExample.workflow.yaml Co-authored-by: Frank Kilcommins <[email protected]> * Update versions/1.0.0.md Co-authored-by: Frank Kilcommins <[email protected]> --------- Co-authored-by: Frank Kilcommins <[email protected]> * Remove references to WHATWG to avoid confusion (#145) * Remove references to WHATWG to avoid confusion * Correct relative reference wording * Section 4.2 not 4.1! * Simplify URI wording * Adjust Step Parameters desc to cater for Workflow parameters addition (#169) * feat: add `dependsOn` capability for workflow level (#164) * feat: add `dependsOn` capability for workflow level * chore: typo fix * chore: grammer fix * feat: Add Request Body Object (#162) * feat: Add Request Body Object * chore: fix typos in examples * Clarity on referencing Components Parameters (#149) * Clarity on referencing Components Parameters * Remove Reference Object to avoid clash with JSON Schema keyword. Replace with expression based referencing * chore: keep fixed field link names consistent * chore: Name component parameters as type Reusable Parameter Object * chore: adjust Workflow level parameters to use Reusable Parameter Objects --------- Co-authored-by: Dmytro Anansky <[email protected]> Co-authored-by: Nick Denny <[email protected]>
* feat: adding support for share success and failure actions * Merging latest 'main' changes in to Action Object Extensions branch (#170) * chore: suggest multilevel parameters (#155) * chore: suggest multilevel parameters * Update versions/1.0.0.md Co-authored-by: Frank Kilcommins <[email protected]> * Update examples/1.0.0/ExtendedParametersExample.workflow.yaml Co-authored-by: Frank Kilcommins <[email protected]> * Update versions/1.0.0.md Co-authored-by: Frank Kilcommins <[email protected]> --------- Co-authored-by: Frank Kilcommins <[email protected]> * Remove references to WHATWG to avoid confusion (#145) * Remove references to WHATWG to avoid confusion * Correct relative reference wording * Section 4.2 not 4.1! * Simplify URI wording * Adjust Step Parameters desc to cater for Workflow parameters addition (#169) * feat: add `dependsOn` capability for workflow level (#164) * feat: add `dependsOn` capability for workflow level * chore: typo fix * chore: grammer fix * feat: Add Request Body Object (#162) * feat: Add Request Body Object * chore: fix typos in examples * Clarity on referencing Components Parameters (#149) * Clarity on referencing Components Parameters * Remove Reference Object to avoid clash with JSON Schema keyword. Replace with expression based referencing * chore: keep fixed field link names consistent * chore: Name component parameters as type Reusable Parameter Object * chore: adjust Workflow level parameters to use Reusable Parameter Objects --------- Co-authored-by: Dmytro Anansky <[email protected]> Co-authored-by: Nick Denny <[email protected]> * Add Reusable Object and referencing ability * chore: fix yaml example indentation * chore: fix JSON examples * chore: fix typo in `workflowStepActions` --------- Co-authored-by: Dmytro Anansky <[email protected]> Co-authored-by: Nick Denny <[email protected]>
fixes #129