Skip to content

[dev] Source code updates from dotnet/dotnet #6702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk (Version 10.0.0-beta.25401.103 -> 10.0.0-beta.25409.103)

Added Dependencies:
Microsoft.DotNet.XliffTasks (Version 10.0.0-beta.25409.103)
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner August 11, 2025 05:01
@ViktorHofer
Copy link
Contributor

ViktorHofer commented Aug 11, 2025

@nkolev92 @jeffkl this brings these VMR changes in:

@dkurepa any idea why the "Do not automerge downgrades" job fails?

@dkurepa
Copy link
Contributor

dkurepa commented Aug 11, 2025

@nkolev92 @jeffkl this brings these VMR changes in:

@dkurepa any idea why the "Do not automerge downgrades" job fails?

no idea currently, especially because the dependency is being added. I will create an issue for this to investigate it.
On a side note, since we have to remove the automerge from Maestro anyway, do you think we should keep this check?

@ViktorHofer
Copy link
Contributor

ViktorHofer commented Aug 11, 2025

Yes, I think this check is highly valuable, regardless of auto-merge.

@dkurepa
Copy link
Contributor

dkurepa commented Aug 11, 2025

I reproed the backflow locally, it appears that this happens every time there's a new dependency because the From version doesn't exist. We'll fix it, thanks for letting us know

nkolev92
nkolev92 previously approved these changes Aug 11, 2025
ViktorHofer
ViktorHofer previously approved these changes Aug 12, 2025
@ViktorHofer
Copy link
Contributor

Can someone please force merge this PR? The "Do not automerge downgrades" job failure is a false positive.

@nkolev92 nkolev92 dismissed stale reviews from ViktorHofer and themself via 15dd747 August 12, 2025 22:21
@nkolev92 nkolev92 requested a review from jeffkl August 12, 2025 22:21
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/dotnet:

@dotnet/product-construction

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/dotnet) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@ViktorHofer ViktorHofer merged commit fab0caa into dev Aug 14, 2025
23 checks passed
@ViktorHofer ViktorHofer deleted the darc-dev-8c407223-33ec-4803-93b2-7e474c311942 branch August 14, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants