Use System.Text.Json source generator for .nupkg.metadata serialization #6701
+22
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14111
Description
Use System.Text.Json source generator, rather than reflection based (de)serialization, for .nupkg.metadata files.
Note this does not make NuGet.Packaging AoT/trimming compatible, due to
NuGet.Client/src/NuGet.Core/NuGet.Packaging/Signing/Utility/MarshalUtility.cs
Line 13 in cc84846
PR Checklist
Added testsexisting tests cover .nupkg.metadata reading & writing. As Support AOT/Trimmed applications that would like to use NuGet libraries Home#14408 says, MSBuild property IsAotCompatible=true can give compiler warnings/errors, but MarshalUtility causes it to fail the project, so that needs to be fixed first.Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A