Skip to content

Stop ilmerging pack #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2025
Merged

Stop ilmerging pack #6697

merged 5 commits into from
Aug 12, 2025

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Aug 8, 2025 •
edited
Loading

Bug

Fixes: NuGet/Home#13079

Description

Stop ilmerging pack.
We don't think we need it anymore, whatever assembly loading issues we had, were probably related to the fact that the pack sdk could not load dependencies from outside of the task directory, but I think MSBUild has long changed that now.

The pack structure is still correct:

│   icon.png
│   NOTICES.txt
│   NuGet.Build.Tasks.Pack.nuspec
│   README.md
│   [Content_Types].xml
│
├───build
│       NuGet.Build.Tasks.Pack.targets
│
├───buildCrossTargeting
│       NuGet.Build.Tasks.Pack.targets
│
├───CoreCLR
│   │   NuGet.Build.Tasks.Pack.dll
│   │   NuGet.Commands.dll
│   │   NuGet.Common.dll
│   │   NuGet.Configuration.dll
│   │   NuGet.Credentials.dll
│   │   NuGet.DependencyResolver.Core.dll
│   │   NuGet.Frameworks.dll
│   │   NuGet.LibraryModel.dll
│   │   NuGet.Packaging.dll
│   │   NuGet.ProjectModel.dll
│   │   NuGet.Protocol.dll
│   │   NuGet.Versioning.dll
│   │
│   ├───cs
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───de
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───es
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───fr
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───it
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───ja
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───ko
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───pl
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───pt-BR
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───ru
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───tr
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───zh-Hans
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   └───zh-Hant
│           NuGet.Build.Tasks.Pack.resources.dll
│           NuGet.Commands.resources.dll
│           NuGet.Common.resources.dll
│           NuGet.Configuration.resources.dll
│           NuGet.Credentials.resources.dll
│           NuGet.DependencyResolver.Core.resources.dll
│           NuGet.Frameworks.resources.dll
│           NuGet.LibraryModel.resources.dll
│           NuGet.Packaging.resources.dll
│           NuGet.ProjectModel.resources.dll
│           NuGet.Protocol.resources.dll
│           NuGet.Versioning.resources.dll
│
├───Desktop
│   │   Microsoft.Bcl.AsyncInterfaces.dll
│   │   Microsoft.Extensions.FileProviders.Abstractions.dll
│   │   Microsoft.Extensions.FileSystemGlobbing.dll
│   │   Microsoft.Extensions.Primitives.dll
│   │   Newtonsoft.Json.dll
│   │   NuGet.Build.Tasks.Pack.dll
│   │   NuGet.Commands.dll
│   │   NuGet.Common.dll
│   │   NuGet.Configuration.dll
│   │   NuGet.Credentials.dll
│   │   NuGet.DependencyResolver.Core.dll
│   │   NuGet.Frameworks.dll
│   │   NuGet.LibraryModel.dll
│   │   NuGet.Packaging.dll
│   │   NuGet.ProjectModel.dll
│   │   NuGet.Protocol.dll
│   │   NuGet.Versioning.dll
│   │   System.Buffers.dll
│   │   System.Collections.Immutable.dll
│   │   System.Memory.dll
│   │   System.Numerics.Vectors.dll
│   │   System.Runtime.CompilerServices.Unsafe.dll
│   │   System.Text.Encodings.Web.dll
│   │   System.Text.Json.dll
│   │   System.Threading.Tasks.Extensions.dll
│   │   System.ValueTuple.dll
│   │
│   ├───cs
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───de
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───es
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───fr
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───it
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───ja
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───ko
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───pl
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───pt-BR
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───ru
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───tr
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   ├───zh-Hans
│   │       NuGet.Build.Tasks.Pack.resources.dll
│   │       NuGet.Commands.resources.dll
│   │       NuGet.Common.resources.dll
│   │       NuGet.Configuration.resources.dll
│   │       NuGet.Credentials.resources.dll
│   │       NuGet.DependencyResolver.Core.resources.dll
│   │       NuGet.Frameworks.resources.dll
│   │       NuGet.LibraryModel.resources.dll
│   │       NuGet.Packaging.resources.dll
│   │       NuGet.ProjectModel.resources.dll
│   │       NuGet.Protocol.resources.dll
│   │       NuGet.Versioning.resources.dll
│   │
│   └───zh-Hant
│           NuGet.Build.Tasks.Pack.resources.dll
│           NuGet.Commands.resources.dll
│           NuGet.Common.resources.dll
│           NuGet.Configuration.resources.dll
│           NuGet.Credentials.resources.dll
│           NuGet.DependencyResolver.Core.resources.dll
│           NuGet.Frameworks.resources.dll
│           NuGet.LibraryModel.resources.dll
│           NuGet.Packaging.resources.dll
│           NuGet.ProjectModel.resources.dll
│           NuGet.Protocol.resources.dll
│           NuGet.Versioning.resources.dll
│
├───package
│   └───services
│       └───metadata
│           └───core-properties
│                   0789d8c3ca9e4c60818cdaabbc900037.psmdcp
│
└───_rels
        .rels

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests Tests exist
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. No impact on customers

@nkolev92 nkolev92 marked this pull request as ready for review August 8, 2025 18:48
@nkolev92 nkolev92 requested a review from a team as a code owner August 8, 2025 18:48
@nkolev92 nkolev92 mentioned this pull request Aug 8, 2025
Merged
donnie-msft
donnie-msft previously approved these changes Aug 8, 2025
View reviewed changes
jeffkl
jeffkl previously approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put so much work into those targets 😆

@nkolev92 nkolev92 dismissed stale reviews from jeffkl and donnie-msft via 04106c6 August 11, 2025 21:10
@nkolev92 nkolev92 force-pushed the dev-nkolev92-stopIlmergingPackV2 branch from cff9768 to 04106c6 Compare August 11, 2025 21:10
@nkolev92 nkolev92 merged commit 7b9e013 into dev Aug 12, 2025
17 of 18 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-stopIlmergingPackV2 branch August 12, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnie-msft donnie-msft donnie-msft approved these changes

@martinrrm martinrrm Awaiting requested review from martinrrm martinrrm is a code owner automatically assigned from NuGet/nuget-client-pull-request-auto-assignment

@jeffkl jeffkl Awaiting requested review from jeffkl

@zivkan zivkan Awaiting requested review from zivkan

@mmitche mmitche Awaiting requested review from mmitche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop ilmerging pack
5 participants
@nkolev92 @zivkan @mmitche @jeffkl @donnie-msft