-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add ability for task options to be hidden from the CLI #7591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ab394ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2008be7 to
6b2ed9a
Compare
| name: "arg", | ||
| defaultValue: "default", | ||
| hidden: true, | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use .addFlag here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the test on line 515 work, or did you mean something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that, sorry. Yes, I think that works.
Btw, I was a bit confused at first because it looked like you were removing an existing test, but it turns out that test is duplicated for some reason?
And it seems like there's another duplication in this file: the tests in lines 1391 and 1420. I know that's unrelated to this PR, but (assuming I'm not wrong) we should delete one of those two. Or replace the second one with a test for the hidden option, like you did with the one in line 515, if it makes sense there too; up to you.
closes #7426