Skip to content

Conversation

@zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Oct 20, 2025

closes #7426

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: ab394ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nomicfoundation/hardhat-errors Patch
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

name: "arg",
defaultValue: "default",
hidden: true,
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use .addFlag here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test on line 515 work, or did you mean something else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that, sorry. Yes, I think that works.

Btw, I was a bit confused at first because it looked like you were removing an existing test, but it turns out that test is duplicated for some reason?

And it seems like there's another duplication in this file: the tests in lines 1391 and 1420. I know that's unrelated to this PR, but (assuming I'm not wrong) we should delete one of those two. Or replace the second one with a test for the hidden option, like you did with the one in line 515, if it makes sense there too; up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the support for the programatic-only options

4 participants