Skip to content

mdbook: fix rust 1.91 tests #459172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

mdbook: fix rust 1.91 tests #459172

merged 1 commit into from
Nov 7, 2025

Conversation

@nekowinston
Copy link
Member

@nekowinston nekowinston commented Nov 6, 2025 •
edited
Loading

Updating a test fixture for Rust 1.91, mentioned in #457185 (comment). Checked locally and got mdbook to compile.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. labels Nov 6, 2025
winterqt
winterqt approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 6, 2025
matthiasbeyer
matthiasbeyer approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch is in master in upstream 👍

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Nov 7, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci nixpkgs-ci bot added this pull request to the merge queue Nov 7, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 7, 2025

@matthiasbeyer wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ✅ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ matthiasbeyer is a member of @NixOS/nixpkgs-maintainers.
  • ✅ matthiasbeyer is a maintainer of all touched packages.

✔️ Queued for merge (#306934)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 7, 2025
Merged via the queue into NixOS:staging with commit 1f4665b Nov 7, 2025
56 of 58 checks passed
@nekowinston nekowinston deleted the mdbook/fix-rust-1.91-tests branch November 7, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@winterqt winterqt winterqt approved these changes

@Frostman Frostman Awaiting requested review from Frostman

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nekowinston @matthiasbeyer @winterqt