Skip to content

rumdl: 0.0.166 -> 0.0.169 #458100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2025
Merged

rumdl: 0.0.166 -> 0.0.169 #458100

merged 1 commit into from
Nov 8, 2025

Conversation

@kachick
Copy link
Member

@kachick kachick commented Nov 3, 2025 •
edited
Loading

The last nixpkgs-update run failed due to an upstream change. Rumdl 0.0.170 requires rustc 1.91.0 or later.
Even so, the PR to update rustc in nixpkgs is not yet in master or staging.

I created this patch using nix-update with this command:

nix-update rumdl --version 0.0.169 --commit

Diff: rvben/rumdl@v0.0.166...v0.0.169

Changelog: https://github.com/rvben/rumdl/blob/v0.0.169/CHANGELOG.md

I tested 0.0.169 locally with rumdl check and rumdl fmt on some files.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

cc: @Hasnep

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 3, 2025
@kachick kachick marked this pull request as ready for review November 3, 2025 14:05
@nix-owners nix-owners bot requested a review from Hasnep November 3, 2025 14:05
@kachick
Copy link
Member Author

kachick commented Nov 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 458100
Commit: a783a81473a7657c76410ad9f99f3ea2b4ed2fce

x86_64-linux

✅ 1 package built:
  • rumdl

aarch64-linux

✅ 1 package built:
  • rumdl

x86_64-darwin

✅ 1 package built:
  • rumdl

aarch64-darwin

✅ 1 package built:
  • rumdl

Hasnep
Hasnep approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@Hasnep Hasnep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on my machine and ran on some markdown files, all working :)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 4, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Nov 8, 2025
Merged via the queue into NixOS:master with commit 7cc7b75 Nov 8, 2025
40 of 42 checks passed
@kachick
Copy link
Member Author

kachick commented Nov 9, 2025

Thank you for reviewing and merging!

@kachick kachick deleted the update-rumdl-without-rustc1.91 branch November 9, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Hasnep Hasnep Hasnep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kachick @Hasnep @Sigmanificient