colmap: 3.9.1 -> 3.12.5-unstable-openimageio, poselib: init at 2.0.5 #438672

chpatrick · 2025-08-30T17:04:10Z

I'm picking up #390412 by @usertam. This PR additionally upgrades to the unstable OpenImageIO branch.

Outstanding problems:

~~COLMAP uses FreeImage which is very insecure and abandoned, although they intend to replace it with OpenImageIO (3384). This is in progress: colmap/colmap#3459~~

libjpeg-turbo in nixpkgs recently dropped support for FreeImage (608422bd4ba434d02278602bc74c46d10bfde2ba). This is totally understandable, but unfortunately it means people can't build COLMAP even at their own risk. I've reverted this now, but I'm not sure that's the best thing to do.

Things done

Add a 👍 reaction to pull requests you find important.

nh2

Overall look good to me. I reviewed and did not test.

I mark as "Request changes" only because:

the formatting CI fails; OK to merge from my side once that's fixed
this needs to target staging because of 10.rebuild-linux: 5001+ ; probably because of the libjpeg_turbo patch removal revert

pkgs/by-name/co/colmap/package.nix

pkgs/by-name/li/libjpeg_turbo/package.nix

pkgs/by-name/po/poselib/package.nix

pkgs/development/python-modules/pycolmap/default.nix

chpatrick · 2025-09-08T19:05:51Z

Per discussions on matrix I switched it to the latest state of the COLMAP OpenImageIO branch. This depends on #419220 or #438171.

nh2

Generally looks good but the mega-patch needs some handling. Godo to merged after that in my opinion.

pkgs/by-name/co/colmap/package.nix

pkgs/development/python-modules/pycolmap/default.nix

SomeoneSerge · 2025-09-30T08:42:48Z

pkgs/by-name/co/colmap/package.nix

+    cudatoolkit
+    cudaPackages.cuda_cudart.static


While moving this code and in case you're interested in picking up maintainership of colmap:

cudaPackagages.cudatoolkit is a symlinkJoin of a bunch of other things and we try to avoid it

lib.getStatic

Also a bit confusing to call these pythonDeps

That all sounds good but I'm not sure how that works and it sounds like it would need upstream to switch to FindCudaToolkit. We can do it, but I'd like to get the package unbroken first.

SomeoneSerge · 2025-09-30T08:50:17Z

pkgs/by-name/co/colmap/package.nix

  ]
  ++ lib.optionals cudaSupport [
    autoAddDriverRunpath
  ];

+  passthru.updateScript = gitUpdater { };
+  passthru.pythonDeps = pythonDeps;


Passthru are weird about splicing... I wonder if the better choice would be to just add a dev output and use propagatedBuildInputs (propagatedNativeBuildInputs for cuda_nvcc)

(even though, conceptually, I wish Nixpkgs used propagatedBuildInputs less, and passthru more)

@SomeoneSerge What exactly do you mean by "weird about splicing"?

In any case, it seems acceptable to me to do it this way for now to unbreak the package; if a different way is cleaner, we can still do that as a follow-up.

chpatrick · 2025-10-02T22:57:01Z

I have decided to take pycolmap out for now since that depends on pybind 3.0.1 and also on sizmailov/pybind11-stubgen#263. Let's merge this to master first then do pycolmap when the dependencies are solved.

This is needed to get unreleased OpenImageIO support so we can drop FreeImage.

nh2

My requests regarding the patch were addressed, I verified it, and the package builds and runs. Merging.

nh2 · 2025-10-03T20:24:12Z

The ofborg darwin builds are still queued (for 20h by now) amd are blocking the merge button.

So I'll click

[x] Merge without waiting for requirements to be met (bypass rules)

for that, as in the past I have also waited extremely long for Darwin ofborg.

If that's wrong, somebody tell me.

If the package fails on Darwin on Hydra, we can take it out as a follow-up.

chpatrick requested a review from nh2 August 30, 2025 17:04

chpatrick force-pushed the colmap-3.12.5 branch from 36e60b7 to 3ee9e82 Compare August 30, 2025 17:07

nix-owners bot requested review from HarisDotParis, amiloradovsky, bjornfor, kamadorueda, lebastr, prusnak, robsliwi and vcunat August 30, 2025 17:13

chpatrick force-pushed the colmap-3.12.5 branch 2 times, most recently from bbbee45 to 470bfa5 Compare August 30, 2025 18:42

chpatrick changed the title ~~colmap: 3.9.1 -> 3.12.5, poselib: init at 2.0.4~~ colmap: 3.9.1 -> 3.12.5, poselib: init at 2.0.4, python3Packages.colmap: init at 3.12.5 Aug 31, 2025

chpatrick force-pushed the colmap-3.12.5 branch from 0d206fe to 0ab11b0 Compare August 31, 2025 14:10

nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 31, 2025

nix-owners bot requested a review from natsukium August 31, 2025 14:16

magicquark mentioned this pull request Sep 1, 2025

Update Request: colmap 3.9.1 → 3.12.4 #434291

Closed

3 tasks

nh2 requested changes Sep 6, 2025

View reviewed changes

chpatrick force-pushed the colmap-3.12.5 branch 3 times, most recently from 0479796 to 289992c Compare September 8, 2025 19:04

chpatrick changed the title ~~colmap: 3.9.1 -> 3.12.5, poselib: init at 2.0.4, python3Packages.colmap: init at 3.12.5~~ colmap: 3.9.1 -> unstable-2025-08-21, poselib: init at 2.0.4, python3Packages.colmap: init at unstable-2025-08-21 Sep 8, 2025

chpatrick force-pushed the colmap-3.12.5 branch from 289992c to c2c71eb Compare September 8, 2025 19:09

nixpkgs-ci bot removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Sep 8, 2025

nh2 requested changes Sep 29, 2025

View reviewed changes

pkgs/by-name/co/colmap/package.nix Show resolved Hide resolved

pkgs/development/python-modules/pycolmap/default.nix Outdated Show resolved Hide resolved

SomeoneSerge reviewed Sep 30, 2025

View reviewed changes

chpatrick force-pushed the colmap-3.12.5 branch from deb6417 to 712b6f2 Compare October 2, 2025 22:54

chpatrick changed the title ~~colmap: 3.9.1 -> unstable-2025-08-21, poselib: init at 2.0.4, python3Packages.colmap: init at unstable-2025-08-21~~ colmap: 3.9.1 -> unstable-3.12.5-openimageio, poselib: init at 2.0.4 Oct 2, 2025

chpatrick changed the base branch from staging to master October 2, 2025 22:54

nixpkgs-ci bot closed this Oct 2, 2025

nixpkgs-ci bot reopened this Oct 2, 2025

chpatrick changed the title ~~colmap: 3.9.1 -> unstable-3.12.5-openimageio, poselib: init at 2.0.4~~ colmap: 3.9.1 -> 3.12.5-unstable-openimageio, poselib: init at 2.0.4 Oct 2, 2025

chpatrick force-pushed the colmap-3.12.5 branch 2 times, most recently from f46528f to 68417b2 Compare October 2, 2025 23:02

nixpkgs-ci bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 2, 2025

chpatrick force-pushed the colmap-3.12.5 branch from 68417b2 to 95c4a9f Compare October 2, 2025 23:09

usertam and others added 6 commits October 3, 2025 01:23

poselib: init at 2.0.5

a667c6a

colmap: 3.9.1 -> 3.11.1

c2f8b5e

colmap: move to by-name

b7cb0d2

colmap: drop libsForQt5.callPackage

7241a8f

colmap: 3.11.1 -> 3.12.5

328fea7

colmap: 3.12.5 -> 3.12.5-unstable-openimageio

758b83b

This is needed to get unreleased OpenImageIO support so we can drop FreeImage.

chpatrick force-pushed the colmap-3.12.5 branch from 95c4a9f to 758b83b Compare October 2, 2025 23:23

chpatrick changed the title ~~colmap: 3.9.1 -> 3.12.5-unstable-openimageio, poselib: init at 2.0.4~~ colmap: 3.9.1 -> 3.12.5-unstable-openimageio, poselib: init at 2.0.5 Oct 2, 2025

nh2 approved these changes Oct 3, 2025

View reviewed changes

nh2 merged commit 5be2221 into NixOS:master Oct 3, 2025
30 of 32 checks passed

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 3, 2025

Uh oh!

colmap: 3.9.1 -> 3.12.5-unstable-openimageio, poselib: init at 2.0.5 #438672

colmap: 3.9.1 -> 3.12.5-unstable-openimageio, poselib: init at 2.0.5 #438672

Uh oh!

Conversation

chpatrick commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

nh2 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chpatrick commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nh2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SomeoneSerge Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

chpatrick Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

SomeoneSerge Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

nh2 Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

chpatrick commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nh2 left a comment

Choose a reason for hiding this comment

Uh oh!

nh2 commented Oct 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chpatrick commented Aug 30, 2025 •

edited

Loading

nh2 left a comment •

edited

Loading

chpatrick commented Sep 8, 2025 •

edited

Loading

chpatrick commented Oct 2, 2025 •

edited

Loading