-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
shader-slang: 2025.8.1 -> 2025.12.1 #424153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you a lot for fixing the patches! I'll have a look into the circular reference issue, as I'd prefer keeping the separate outputs :) |
Changelogs: - https://github.com/shader-slang/slang/releases/tag/v2025.12.1 - https://github.com/shader-slang/slang/releases/tag/v2025.12 - https://github.com/shader-slang/slang/releases/tag/v2025.11.1 - https://github.com/shader-slang/slang/releases/tag/v2025.11 - https://github.com/shader-slang/slang/releases/tag/v2025.10.5 - https://github.com/shader-slang/slang/releases/tag/v2025.10.4 - https://github.com/shader-slang/slang/releases/tag/v2025.10.3 - https://github.com/shader-slang/slang/releases/tag/v2025.10.2 - https://github.com/shader-slang/slang/releases/tag/v2025.10.1 - https://github.com/shader-slang/slang/releases/tag/v2025.10 - https://github.com/shader-slang/slang/releases/tag/v2025.9.2 - https://github.com/shader-slang/slang/releases/tag/v2025.9.1 - https://github.com/shader-slang/slang/releases/tag/v2025.9 Co-authored-by: Niklas Korz <[email protected]>
0df4540
to
a073be5
Compare
The cyclic dependency was caused by The solution was moving |
|
|
Thanks @niklaskorz for fixing and merging this! As a heads up, this package will need to be manually fixed again for the next Slang release, due to shader-slang/slang#7577 (the build still succeeds on the previous commit shader-slang/slang@00746bf). I'm wondering whether it would make sense to try to upstream any of this into the Slang repo; also cc @expipiplus1 who maintains her own Slang |
Yeah we should definitely upstream these patches, they are breaking too often to maintain them in nixpkgs I'm afraid. |
@niklaskorz the Slang repo currently has a |
Upgrades shader-slang from 2025.8.1 to 2025.12.1
This PR fixes up #416790 by applying the updated patch mentioned in #424144, and then "resolves" the reference cycle error by having the derivation be single-output; this was the only fix I could figure out at the moment with my limited Nix expertise. I don't have a good understanding of what the drawbacks are.
Changelogs:
cc @niklaskorz
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.