-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
rp2040js: init at 1.1.1 #413734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
rp2040js: init at 1.1.1 #413734
Conversation
ea607b1
to
8b5757a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor comments and minor style suggestions which you don't necessarily have to implement.
8b5757a
to
45a723b
Compare
Hi, thanks for the review, just hoping to get a proper |
45a723b
to
c6601b3
Compare
IMO, the version flag and corresponding check are not strictly necessary for derivations. Of course it makes automatic updates easier, but in the meantime also manual testing updates can be done. |
Initialized the
rp2040js
package, a javascript based emulator for the raspberry pi pico rp2040.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)It should be mentioned that by default the original repository is mainly geared towards usage as a library. Hence, the main module of
index.ts
is not usable in any fashion from the command line, and insteaddemo/emulator-run.ts
is, which is intended by the authors. Hence therp2040js
binary provided to this package maps tonpm run start
. This is accomplished via the patch to thetsconfig.json
file.Also of note is that when no
--image
flag is provided it will look for a binary file calledhello_uart.hex
in the base of the project to run instead. This was not provided here as I believe it does not make sense to bake into this package considering--image
makes the most sense for regular useAdd a 👍 reaction to pull requests you find important.