-
-
Notifications
You must be signed in to change notification settings - Fork 17.1k
cbqn: 0.8.0 -> 0.9.0 #393072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
cbqn: 0.8.0 -> 0.9.0 #393072
Conversation
Also other sources were updated: - cbqn-bytecode: 0-unstable-2024-09-15 -> 0-unstable-2025-03-16 - replxx: didn't change - singeli: 0-unstable-2024-09-29 -> 0-unstable-2025-03-13
0fa9747 to
4700084
Compare
4700084 to
f284731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a PR with just the update (#400662) and will merge that as soon as CI passes, thanks. I think that change should be uncontroversial.
I don't really have an opinion on using fetchSubmodules, though actually using git for fetching can be slow and brittle – not sure. Maybe @AndersonTorres can describe why they implemented it as they did and whether it should or should not be changed?
I don't like moving cbqn to by-name, it doesn't really make sense for this sort of thing and makes the bootstrapping wiring-up in all-packages.nix even more confusing.
| '' | ||
| mkdir -p build/singeliLocal/ | ||
| cp -r ${sources.singeli.src}/* build/singeliLocal/ | ||
| cp -r build/singeliSubmodule/* build/singeliLocal/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the mkdir before, it can become
| cp -r build/singeliSubmodule/* build/singeliLocal/ | |
| mv build/singeliSubmodule/ build/singeliLocal |
Should also work for the other instances of this!
Obscure things about reproducibility. I remember some specific, illustrative examples like the yuzu corpse.
|
|
Thanks for the input. The thoughts I have on fetchSubmodules is that we don't have any patch at the moment and that it seems to be unhappy with newer version of submodules (it will not build). Also we don't really use much git metadata and we have fixed input with hash as well, so probably no problems with reproducibility. What do you think? @sternenseemann @AndersonTorres |
|
I have no feelings on this. |
|
cbqn is at 0.9.0 on master, please rebase. |
Resolves #391350.
This PR removes sources.nix entirely by using fetchSubmodules.
It also moves the package to by-name (RFC 0140).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.