libexpr: Remove the source accessor from path values and ExprPaths #14117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Co-authored-by: Eelco Dolstra <[email protected]> We can use the rootFS accessor for everything and just mount any other accessor (like corepkgsFS) on top of that. 1. removes 16 bytes per ExprPath 2. enables us in the future to shrink path value payload to 8 bytes 3. enables us in the future to directly refer to path values where we are currently referring to ExrPaths that forward us to a path value 4. enables getting rid of enable_shared_from_this<SourceAccessor>
Radvendii
force-pushed
the
remove-accessor-field
branch
from
daca17d to
a1262c2
Compare
Contributor
Author
|
After further discussion on the nix-maintainers call, we're going to postpone this change until we know exactly what we want things to look like. It's not going to block any progress until we get to decreasing the size of Value payload, which isn't for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See [this tracking issue] for more big-picture motivation
Context
Discussed with Eelco here (and on the nix maintainers call): #14106 (comment)
Eelco's original work: DeterminateSystems@4c02828#diff-531b7e0b6ecbff13af7eeb43f6273b7349912536c225532f8ce4144234fe9c72
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
CC @xokdvium @NaN-git @Ericson2314