Re-introduce mkStringNoCopy (revised) #13890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b70d22b `mkStringNoCopy()` was renamed to `mkString()`, but this is a bit risky since in code like vStringRegular.mkString("regular"); we want to be sure that the right overload is picked. (This is especially problematic since the overload that takes an `std::string_view` *does* allocate.) So let's be explicit. (Rebased from NixOS#11551)
This would lead to an unnecessary allocation. Not a significant issue by any means, but it doesn't have to allocate for most cases.
Ericson2314
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In b70d22b
mkStringNoCopy()was renamed tomkString(), but this is a bit risky since in code likewe want to be sure that the right overload is picked. (This is
especially problematic since the overload that takes an
std::string_viewdoes allocate.) So let's be explicit.(Rebased from #11551)
Context
The first commit is rebased from #11551, the other one is makes
prim_typeOfnot copy string literals.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.