Skip to content

Conversation

ivankristianto
Copy link
Contributor

@ivankristianto ivankristianto commented Jan 30, 2022

Add Search Feature To Backend Administration

This PR allows user to do search query for all lists inside the backend administration.
These are the dashboard list that now has search function:

  1. Proxy
  2. Redirection
  3. Stream
  4. 404
  5. Audit Logs
  6. SSL Certificates
  7. Users

The search query parameter is available and builtin from the api backend. This PR is to add the UI and the query param to the API.

Video Demo:

npm.mp4

@jc21
Copy link
Member

jc21 commented Jan 30, 2022

This is an automated message from CI:

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1822

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21
Copy link
Member

jc21 commented Jan 30, 2022

Awesome stuff, can't see anything wrong with it :) If you apply this to all the lists (where possible) then I'll put the PR through it's paces before merging. Thanks!

@ivankristianto
Copy link
Contributor Author

Thanks @jc21

Quick question: Should I continue to apply this to all possible list in this same PR or you prefer I separate it for each list?

@jc21
Copy link
Member

jc21 commented Jan 31, 2022

Same PR please

@ivankristianto ivankristianto changed the title Add Search function for Redirection Add Search Feature To Backend Administration Feb 12, 2022
@ivankristianto
Copy link
Contributor Author

@jc21 This PR now completed and ready for your review / tests.
The Jenkins CI has failed but not due to the code changes, And I cannot manually re-trigger it. I wonder what can I do to help?

@jc21
Copy link
Member

jc21 commented Feb 13, 2022

This is an automated message from CI:

Docker Image for build 4 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1822

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21 jc21 merged commit 14b889a into NginxProxyManager:develop Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants