fix(cli): new config default path #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CLI configuration path handling where the default config path determination could fail when namespace.config is a list. The change ensures that when namespace.config is a list, the first element is properly extracted as the configuration path.
- Updated the default config path logic to handle list values
- Added type checking to extract the first element when
namespace.configis a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor update to the
ddns/config/cli.pyfile. The change refines how the default configuration path is determined when theconfigattribute innamespaceis a list.ddns/config/cli.py: Updated the logic for settingconfig_pathto handle cases wherenamespace.configis a list, ensuring the first element of the list is used as the path.