Skip to content

Conversation

ehennestad
Copy link
Contributor

@ehennestad ehennestad commented Mar 7, 2025

Fix #611

Summary of changes

Change quantity from "*" to "+" for groups of wrapper types

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
  • Make sure that hdmf-common-schema points to the latest release and not the latest commit on the main branch.

@ehennestad ehennestad requested review from rly and stephprince March 7, 2025 08:49
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @ehennestad

@rly rly merged commit f647baa into dev Mar 19, 2025
4 checks passed
@rly rly deleted the 611-fix-group-quantity-of-wrapper-types branch March 19, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some wrapper types/interfaces (i.e, BehavioralEpochs) can have 0 elements
3 participants