Skip to content

Conversation

guillaume-chevalier
Copy link
Member

@guillaume-chevalier guillaume-chevalier commented Mar 24, 2025

Updates:

  • Updated sklearn to a new version and fix related issues

@cla-bot cla-bot bot added the cla-signed label Mar 24, 2025
@Neuraxio Neuraxio deleted a comment from pull-checklist bot Mar 24, 2025
@pull-checklist
Copy link

pull-checklist bot commented Mar 24, 2025

Things to check at each Pull Request (PR)

  • Your local Git username is set to your GitHub username, and your local Git email is set to your GitHub email. This is important to avoid breaking the cla-bot and for your contributions to be linked to your profile. More info: https://github.com/settings/emails
  • Argument's dimensions and types are specified for new steps (important), with examples in docstrings when needed.
  • Class names and argument / API variables are very clear: there is no possible ambiguity. They also respect the existing code style (avoid duplicating words for the same concept) and are intuitive.
  • Use typing like variable: Typing = ... as much as possible. Also use typing for function arguments and return values like def my_func(self, my_list: Dict[int, List[str]]) -> OrderedDict[int, str]:.
  • Classes are documented: their behavior is explained beyond just the title of the class. You may even use the description written in your pull request above to fill some docstrings accurately.
  • If a numpy array is used, it is important to remember that these arrays are a special type that must be documented accordingly, and that numpy array should not be abused. This is because Neuraxle is a library that is not only limited to transforming numpy arrays. To this effect, numpy steps should probably be located in the existing numpy python files as much as possible, and not be all over the place. The same applies to Pandas DataFrames.
  • Code coverage is above 90% for the added code for the unit tests.
  • Respect the Unit Testing status check
  • Respect the Codacy status check
  • Respect the cla-bot status check (unless the cla-bot is truly broken - please try to debug it first)
  • The above description of the pull request in natural language was used to document the new code inside the code's docstrings so as to have complete documentation, with examples.
  • Code files that were edited were reformatted automatically using PyCharm's Ctrl+Alt+L shortcut.

New contributor? Ensure you do this.

  • Your local Git username is set to your GitHub username, and your local Git email is set to your GitHub email. This is important to avoid breaking the cla-bot and for your contributions to be linked to your profile. If at least 1 contribution is not commited properly using the good credentials, the cla-bot will break until your re-commit it.
  • Use the PyCharm IDE with PyTest to test your code. Reformatting your code at every file save is a good idea, using PyCharm's Ctrl+Alt+L shortcut. You may reorganize imports automatically as well, as long as your project root is well configured. Run the tests to see if everything works, and always ensure that all tests run before opening a pull request as well.
  • We recommend letting PyCharm manage the virtual environment by creating a new one just for this project, and using PyTest as a test runner in PyCharm. This is not required, but should help in getting you started.
  • Please make your pull request(s) editable, such as for us to add you to the list of contributors if you didn't add the entry, for example.
  • To contribute, first fork the project, then do your changes, and then open a pull request in the main repository.
  • Sign the Contributor License Agreement (CLA) to allow Neuraxio to use and publish your contributions under the Apache 2.0 license, in order for everyone to be able to use your open-source contributions. Follow the instructions of the cla-bot upon opening the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant