Skip to content

Conversation

sgedward
Copy link
Contributor

@sgedward sgedward commented Oct 22, 2017

#55

Change:
slack_comm.py

@mikegrima
Copy link
Contributor

Hello @sgedward. Would prefer not making use of globals.

I think this would be best accomplished by having a function to return a timestamp, and having thread sent in via a keyword arg to the say* functions.

I think an approach similar to #63 would best implement this feature.

@sgedward
Copy link
Contributor Author

@mikegrima thanks for leting me know. fixed

@mikegrima
Copy link
Contributor

Testing this today

@mikegrima
Copy link
Contributor

@sgedward slight merge conflict that should be very easy to fix.

@mikegrima
Copy link
Contributor

I'll fix the conflict -- some changes I need to make to incorporate this PR with the ephemeral messages one.

@mikegrima mikegrima merged commit 6095d00 into Netflix:develop Oct 29, 2017
@mikegrima mikegrima mentioned this pull request Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants