Make Genie agent container's entry point and command dynamic #1251
+74
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgshep
reviewed
Aug 5, 2025
| when: | ||
| def entryPointTemplate = ["my", "entrypoint"] | ||
| def commandTemplate = ["my", "command"] | ||
| environment.withProperty( |
There was a problem hiding this comment.
What happens if the property is malformed?
There was a problem hiding this comment.
In that case, the Titus container will still launch, but it will fail finally. This change is mainly intended to help with testing and rolling out changes related to the entry point or command. The default values are stored in property files like application.yml, so we don't anticipate needing a long-term fast property for this scenario.
dgshep
approved these changes
Aug 5, 2025
bhou2
approved these changes
Aug 5, 2025
genie-web/src/main/java/com/netflix/genie/web/agent/launchers/impl/TitusAgentLauncherImpl.java
Show resolved
Hide resolved
genie-web/src/main/java/com/netflix/genie/web/agent/launchers/impl/TitusAgentLauncherImpl.java
Show resolved
Hide resolved
genie-web/src/main/java/com/netflix/genie/web/properties/TitusAgentLauncherProperties.java
Show resolved
Hide resolved
genie-web/src/main/java/com/netflix/genie/web/properties/TitusAgentLauncherProperties.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the entry point and command properties dynamic for Titus Launcher
What changed?
genie.agent.launcher.titus.entry-point-templategenie.agent.launcher.titus.command-template