Target selectors for ix.command.FindPlayer #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….command.FindPlayer
…e length & changed wording a bit
DoopieWop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two target selectors for chat commands: "^" targets the command caller, while "@" targets whoever the command caller is looking at, this also works with ragdolled players (as well as many others as it relies on the "ixPlayer" member variable that is used in certain places, like the scanner in the default HL2RP schema)
The local function "ArgumentCheckStub" in core/sh_commands.lua now uses ix.command.FindPlayer (which this PR changes), instead of ix.util.FindPlayer (which has not been changed).
Documentation for the ix.command.FindPlayer function was updated accordingly.
The functionality and basic code is inspired by NutScript's implementation.