Added SplitLookupOperation to Qonduit #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
commented
May 14, 2025
| writer.append(key, encodedPrev); | ||
| } | ||
| LOG.debug("Splits file {} complete for {}", tableSplitsFile, tableName); | ||
| SPLIT_FILES.computeIfAbsent(tableName, (t) -> new AtomicReference<Path>()).set(tableSplitsFile); |
There was a problem hiding this comment.
I'm thinking I should remove the old file here. Might be safer to perform the check in SplitLookupOperation and delete the file if the RFile that was just read from is not the current reference.
| Text prevRow = TabletColumnFamily.decodePrevEndRow(entry.getValue()); | ||
| response.setBeginRow(prevRow == null ? "null" : prevRow.toString()); | ||
| response.setEndRow(endRow == null ? "null" : endRow.toString()); | ||
| } |
There was a problem hiding this comment.
Could call server.getSplitStore().getSplitsFileForTable(tableName) after this, and if not equal to splitsFile, then remove splitsFile as the file we just read from is no longer the current file. If old file is not read from for a long time, then it could lead to a bunch of files piling up on disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Qonduit server to optionally serve up split
information for user tables. When enabled the SplitStore
component in the Qonduit server will periodically get
the splits for user tables and store them in RFiles on
local disk (location can be configured).
Users can use the
WebSocketClientobjectto connect to the Qonduit server and send
SplitLookupRequestobjects over the connection.On the server side, the request is routed to the
SplitLookupOperationclass where the row issearched in the split file for the table. The operation
returns a
SplitLookupResponseobject back tothe user.
Included several IT changes, including an IT that
shows how to wire everything together.