Support builds with jdk17 and newer #3071
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddanielr
force-pushed
the
feature/ctubbsii-support-builds-with-jdk17-and-newer
branch
2 times, most recently
from
4e9b436 to
e6fdd9d
Compare
POM changes: * Add maven.compiler.release option to force correct cross-compilation to Java 11 when building with a JDK newer than 11, such as JDK 17 * Remove unnecessary java source, target, and encoding config from plugins when those are already specified by properties * Also fix the license name for Apache-2.0 (the recommended name is the SPDX name) and drop .txt from the license URL * Remove redundant items in POMs * Update spotbugs-maven-plugin so it works with newer JDKs * Configure javadoc doclint to 'all,-missing' to prevent noise from missing javadocs Other build changes: * Update GitHub Actions to test build with JDK 17 Code changes: * Fix spotbugs issues regarding unnecessary boxing/unboxing primitives * Fix javadoc headers and html conventions for more strict enforcement on newer JDKs * Fix javadoc issues about the use of uppercase header elements, which breaks the standard conventions of html5 that carried over from XHTML days, which was case-sensitive (and because uppercase looks ugly) * Also fix a few other places where uppercase html5 was used, and remove an out-of-place closing paragraph element (that also used uppercase) * Demote `<h1>` tags to `<h2>` in javadoc comments because javadoc reserves `<h1>` for its own generated headers
Adds minor updates to java documentation. Updates log message. Removes deprecated method use. Fixes casting statments
ddanielr
force-pushed
the
feature/ctubbsii-support-builds-with-jdk17-and-newer
branch
from
e6fdd9d to
e15b9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-based branch of changes from #2609.
Moved the original code to a branch on the datawave repo to allow running of the github actions.