Fix healpix test dataloader DistributedSampler #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/blossom-ci |
pzharrington
changed the title
|
/blossom-ci |
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
daviddpruitt
approved these changes
Jul 8, 2025
coreyjadams
pushed a commit
to coreyjadams/physicsnemo
that referenced
this pull request
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Fixes #988, using the test dataset object to instantiate
DistributedSampler. As far as I can tell none of the examples or current known use-cases are exposed to this issue due to not using thetest_dataloadermethod in distributed mode, but good to fix in general.Checklist
Dependencies