Use device minor as suffix in device name instead of the index #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device minor is more stable than the index in terms of not changing once a node has been brought online. The minor number may change across a node reboot, but it wont change if one of the GPUs falls off the bus or is explicitly drained / blocklisted from the driver (whereas the index will adjust for any missing GPUs). Signed-off-by: Kevin Klues <[email protected]>
jgehrcke
approved these changes
Jul 17, 2025
|
When will this PR merged? |
|
@klueska should a similar change be made in the CDI spec generation logic? |
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device minor is more stable than the index in terms of not changing once a node has been brought online. The minor number may change across a node reboot, but it wont change if one of the GPUs falls off the bus or is explicitly drained / blocklisted from the driver (whereas the index will adjust for any missing GPUs).
Fixes #427