[contrib][DistributedFusedLamb] replace apex.parallel.flat_dist_call with coalescing manager in test
#1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaki Kozuki <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the implementation of flat_dist_call within the test suite to replace the old distributed flat call mechanism with one that leverages _coalescing_manager for managing asynchronous operations.
- Removed the old dependency on apex.parallel.distributed.flat_dist_call
- Introduced a new flat_dist_call function using _coalescing_manager and a subsequent cm.wait() call to ensure completion of operations
Comments suppressed due to low confidence (1)
apex/contrib/test/optimizers/test_distributed_fused_lamb.py:12
- [nitpick] Consider adding a brief docstring to flat_dist_call that explains its role and the asynchronous behavior managed by _coalescing_manager for future maintainability.
def flat_dist_call(param_list: list[torch.Tensor], op, args):
crcrpar
changed the title
apex.parallel.flat_dist_call with coalescing manager in test
nWEIdia
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apex.parallelwas removed in #1896