Skip to content

[TRTLLM-6675][infra] Nixl test completion #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 8, 2025

Conversation

bo-nv
Copy link
Collaborator

@bo-nv bo-nv commented Aug 5, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling in benchmarking scripts to prevent issues when expected metrics are missing.
  • New Features

    • Added comprehensive benchmark tests for disaggregated serving performance across multiple backends and models.
    • Introduced new accuracy tests for the nixl backend with DeepSeekV3Lite and Qwen3_8B models.
  • Tests

    • Expanded integration and QA test lists to include new benchmark and accuracy test cases for enhanced coverage.
  • Documentation

    • Updated version badge in README and version constraints to reflect stable 1.0.0 release.
  • Chores

    • Updated package version specifications and renamed several test suite keys for consistency.

Description

The NIXL backend is introduced in https://github.com/NVIDIA/TensorRT-LLM/tree/ed801ff74b4b5bbfc3e381aa635624f0573cc68d/examples/disaggregated, this PR adds some tests to ensure nixl has similar perf with UCX and no accuracy issues.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@bo-nv bo-nv requested review from Shixiaowei02 and chuangz0 August 5, 2025 08:23
Copy link
Contributor

coderabbitai bot commented Aug 5, 2025

Caution

Review failed

Failed to post review comments.

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e575080 and b53bafa.

📒 Files selected for processing (17)
  • README.md (1 hunks)
  • examples/constraints.txt (1 hunks)
  • requirements.txt (1 hunks)
  • tensorrt_llm/serve/scripts/benchmark_serving.py (1 hunks)
  • tensorrt_llm/version.py (1 hunks)
  • tests/integration/defs/accuracy/test_disaggregated_serving.py (2 hunks)
  • tests/integration/defs/disaggregated/test_disaggregated.py (2 hunks)
  • tests/integration/defs/perf/test_perf.py (1 hunks)
  • tests/integration/test_lists/qa/llm_function_full.txt (2 hunks)
  • tests/integration/test_lists/qa/llm_function_sanity.txt (2 hunks)
  • tests/integration/test_lists/qa/llm_perf_cluster.yml (3 hunks)
  • tests/integration/test_lists/qa/llm_perf_full.yml (3 hunks)
  • tests/integration/test_lists/qa/llm_perf_sanity.yml (1 hunks)
  • tests/integration/test_lists/qa/llm_trt_integration_perf.yml (1 hunks)
  • tests/integration/test_lists/qa/llm_trt_integration_perf_sanity.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml (2 hunks)
✅ Files skipped from review due to trivial changes (7)
  • examples/constraints.txt
  • tests/integration/test_lists/qa/llm_trt_integration_perf_sanity.yml
  • tests/integration/test_lists/qa/llm_trt_integration_perf.yml
  • tensorrt_llm/version.py
  • tests/integration/test_lists/qa/llm_perf_sanity.yml
  • README.md
  • tests/integration/defs/perf/test_perf.py
🚧 Files skipped from review as they are similar to previous changes (6)
  • tests/integration/test_lists/qa/llm_function_sanity.txt
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml
  • tensorrt_llm/serve/scripts/benchmark_serving.py
  • tests/integration/test_lists/qa/llm_function_full.txt
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

**/*.py: Python code should conform to Python 3.8+.
Indent Python code with 4 spaces. Do not use tabs.
Always maintain the namespace when importing in Python, even if only one class or function from a module is used.
Python filenames should use snake_case (e.g., some_file.py).
Python classes should use PascalCase (e.g., class SomeClass).
Python functions and methods should use snake_case (e.g., def my_awesome_function():).
Python local variables should use snake_case. Prefix k for variable names that start with a number (e.g., k_99th_percentile).
Python global variables should use upper snake_case and prefix G (e.g., G_MY_GLOBAL).
Python constants should use upper snake_case (e.g., MY_CONSTANT).
Avoid shadowing variables declared in an outer scope in Python.
Initialize all externally visible members of a Python class in the constructor.
For interfaces that may be used outside a Python file, prefer docstrings over comments.
Comments in Python should be reserved for code within a function, or interfaces that are local to a file.
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx.
Attributes and variables in Python can be documented inline; attribute docstrings will be rendered under the class docstring.
Avoid using reflection in Python when functionality can be easily achieved without it.
When using try-except blocks in Python, limit the except to the smallest set of errors possible.
When using try-except blocks to handle multiple possible variable types in Python, keep the body of the try as small as possible, using the else block to implement the logic.

Files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
**/*.{cpp,h,hpp,cc,cxx,cu,py}

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code should contain an NVIDIA copyright header that includes the current year. This includes .cpp, .h, .cu, .py, and any other source files which are compiled or interpreted.

Files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
🧠 Learnings (6)
📓 Common learnings
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/qa/llm_perf_cluster.yml
  • tests/integration/test_lists/qa/llm_perf_full.yml
  • tests/integration/defs/disaggregated/test_disaggregated.py
📚 Learning: 2025-08-06T13:58:07.506Z
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.

Applied to files:

  • tests/integration/test_lists/qa/llm_perf_cluster.yml
  • tests/integration/test_lists/qa/llm_perf_full.yml
  • tests/integration/defs/disaggregated/test_disaggregated.py
📚 Learning: 2025-08-06T03:47:16.802Z
Learnt from: venkywonka
PR: NVIDIA/TensorRT-LLM#6650
File: tests/integration/test_lists/qa/llm_perf_cluster.yml:33-37
Timestamp: 2025-08-06T03:47:16.802Z
Learning: Ministral is a valid model name from Mistral AI, distinct from the regular Mistral models. In TensorRT-LLM test configurations, "ministral_8b" and "ministral_8b_fp8" are correct model identifiers and should not be changed to "mistral_8b".

Applied to files:

  • tests/integration/test_lists/qa/llm_perf_cluster.yml
  • tests/integration/test_lists/qa/llm_perf_full.yml
📚 Learning: 2025-08-06T03:47:16.802Z
Learnt from: venkywonka
PR: NVIDIA/TensorRT-LLM#6650
File: tests/integration/test_lists/qa/llm_perf_cluster.yml:33-37
Timestamp: 2025-08-06T03:47:16.802Z
Learning: Ministral is a valid and distinct model family from Mistral AI, separate from their regular Mistral models. Ministral 8B is specifically designed for edge computing and on-device applications, released in October 2024. In TensorRT-LLM test configurations, "ministral_8b" and "ministral_8b_fp8" are correct model identifiers and should not be changed to "mistral_8b".

Applied to files:

  • tests/integration/test_lists/qa/llm_perf_cluster.yml
📚 Learning: 2025-08-01T15:14:45.673Z
Learnt from: yibinl-nvidia
PR: NVIDIA/TensorRT-LLM#6506
File: examples/models/core/mixtral/requirements.txt:3-3
Timestamp: 2025-08-01T15:14:45.673Z
Learning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.

Applied to files:

  • tests/integration/test_lists/qa/llm_perf_cluster.yml
  • tests/integration/test_lists/qa/llm_perf_full.yml
🔇 Additional comments (6)
requirements.txt (1)

6-6: LGTM! Version constraint follows best practices.

The version constraint >=12,<13 appropriately pins the major version while allowing minor and patch updates, preventing potential breaking changes from major version upgrades.

tests/integration/defs/disaggregated/test_disaggregated.py (3)

17-24: LGTM! Imports are necessary and properly used.

All new imports are appropriately utilized throughout the added functionality for benchmarking and testing.


1059-1087: LGTM! Well-designed fixtures with appropriate scopes.

The fixtures are properly structured:

  • benchmark_root and shared_gpt_path use module scope for efficiency
  • benchmark_model_root uses function scope and includes proper error handling for unknown models
  • Clear separation of concerns and reusable design

1204-1238: LGTM! Clean configuration generation function.

The function provides a clear, structured way to generate serving configurations for different backends while maintaining consistent defaults suitable for benchmarking.

tests/integration/test_lists/qa/llm_perf_full.yml (1)

2-2: Renaming the top-level key may break downstream tooling

All CI jobs, Jenkins parsers, and internal dashboards must be updated to look for llm_perf_full instead of trt_llm_release_perf_test. Please verify that:

  1. tests/integration/utils/collect_test_lists.py (or equivalent) includes the new key.
  2. Any Jenkinsfile, GitLab job template, or reporting notebook that selects the test list by name has been updated.

Otherwise the full perf suite will silently be skipped.

tests/integration/test_lists/qa/llm_perf_cluster.yml (1)

2-2: Cluster list key renamed – confirm orchestration update

As with llm_perf_full, any scheduler or launcher that expects trt_llm_release_perf_cluster_test must be updated, otherwise nightly cluster runs will be empty.

📝 Walkthrough

Walkthrough

This change adds new benchmarking and accuracy tests for disaggregated serving with different backends and models, including DeepSeek and Llama variants. It introduces new test methods, fixtures, and helper functions to support benchmarking, updates test list configurations to include these tests, and improves error handling in benchmark metric extraction.

Changes

Cohort / File(s) Change Summary
Benchmarking Infrastructure & Tests
tests/integration/defs/disaggregated/test_disaggregated.py
Added new pytest fixtures, helper functions, and a parameterized test for benchmarking disaggregated serving with various backends and models. Includes logic for launching processes, running benchmarks, parsing metrics, and asserting backend performance.
Accuracy Tests for Nixl Backend
tests/integration/defs/accuracy/test_disaggregated_serving.py
Added test_nixl_backend methods to TestDeepSeekV3Lite and TestQwen3_8B to evaluate accuracy using the nixl backend.
Benchmark Script Error Handling
tensorrt_llm/serve/scripts/benchmark_serving.py
Updated dictionary comprehension to avoid KeyError by filtering missing keys from results when building metrics.
Test List Updates (YAML)
tests/integration/test_lists/test-db/l0_dgx_b200.yml,
tests/integration/test_lists/test-db/l0_dgx_h100.yml
Appended new benchmark and accuracy test entries for nixl backend and multiple model configurations in the test lists.
Test List Updates (TXT)
tests/integration/test_lists/qa/llm_function_full.txt,
tests/integration/test_lists/qa/llm_function_sanity.txt
Added new test entries for test_nixl_backend in both DeepSeekV3Lite and Qwen3_8B classes.
Version and Dependency Updates
README.md, examples/constraints.txt, requirements.txt, tensorrt_llm/version.py
Updated version from 1.0.0rc6 to 1.0.0 in multiple files; constrained cuda-python package version in requirements.
Performance Test Model Addition
tests/integration/defs/perf/test_perf.py
Added Mistral Small 3.1 24B Instruct model entry to performance test model dictionary.
Performance Test List Updates
tests/integration/test_lists/qa/llm_perf_cluster.yml,
tests/integration/test_lists/qa/llm_perf_full.yml,
tests/integration/test_lists/qa/llm_perf_sanity.yml,
tests/integration/test_lists/qa/llm_trt_integration_perf.yml,
tests/integration/test_lists/qa/llm_trt_integration_perf_sanity.yml
Renamed several test suite keys and added multiple performance test entries for the Mistral Small 3.1 24B model with various configurations and GPU counts; removed one existing test entry from the full performance list.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant Server
    participant MPIWorkers
    participant BenchmarkScript

    TestRunner->>MPIWorkers: Launch MPI worker processes
    TestRunner->>Server: Start server with config
    TestRunner->>Server: Warm up with client script
    TestRunner->>BenchmarkScript: Run benchmark with model/config
    BenchmarkScript->>Server: Send benchmark requests
    Server->>BenchmarkScript: Respond with metrics
    BenchmarkScript-->>TestRunner: Output metrics (E2EL, TTFT)
    TestRunner->>MPIWorkers: Terminate
    TestRunner->>Server: Terminate
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~18 minutes

Suggested labels

Community want to contribute

Suggested reviewers

  • litaotju
  • yilin-void
  • pcastonguay
  • StanleySun639
  • LarryXFly

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bo-nv bo-nv changed the title [TRTLLM-6675][Infra] Nixl test completion [TRTLLM-6675][infra] Nixl test completion Aug 5, 2025
@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 5, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14121 [ run ] triggered by Bot

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (3)
tests/integration/test_lists/qa/examples_test_list.txt (1)

547-548: Maintain alphabetical ordering of test entries

The two newly-added NIXL entries appear underneath miscellaneous lines that are still alphabetically ordered. To keep the long list diff-friendly and minimise future merge conflicts, please insert the new items in the correct alphabetical position (the block is roughly sorted by module name).

tests/integration/test_lists/qa/llm_sanity_test.txt (1)

104-105: Keep the sanity list deterministically ordered

Like the main QA list, the sanity list is intended to stay stable between PRs. Please reorder the two new test_nixl_backend lines so the file remains alphabetically sorted — this prevents noisy diffs when multiple developers touch the list.

tensorrt_llm/serve/scripts/benchmark_serving.py (1)

582-585: Good defensive fix – minor naming nit

The added if k in results guard neatly avoids KeyErrors – nice!
Tiny readability nit: the local list is called metrics, and you also pass a named argument metrics=. Renaming the list to something like metric_keys would avoid the double meaning.

-    metrics = [
+    metric_keys = [
         "median_ttft_ms", "mean_ttft_ms", "std_ttft_ms", "p99_ttft_ms",
@@
-        metrics={k: [results[k]] for k in metrics if k in results},
+        metrics={k: [results[k]] for k in metric_keys if k in results},
-        for k in results if k not in metrics and k not in ignored_metrics
+        for k in results if k not in metric_keys and k not in ignored_metrics
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed801ff and 164d880.

📒 Files selected for processing (7)
  • tensorrt_llm/serve/scripts/benchmark_serving.py (1 hunks)
  • tests/integration/defs/accuracy/test_disaggregated_serving.py (2 hunks)
  • tests/integration/defs/disaggregated/test_disaggregated.py (2 hunks)
  • tests/integration/test_lists/qa/examples_test_list.txt (1 hunks)
  • tests/integration/test_lists/qa/llm_sanity_test.txt (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+.
Indent Python code with 4 spaces. Do not use tabs.
Always maintain the namespace when importing in Python, even if only one class or function from a module is used.
Python filenames should use snake_case (e.g., some_file.py).
Python classes should use PascalCase (e.g., class SomeClass).
Python functions and methods should use snake_case (e.g., def my_awesome_function():).
Python local variables should use snake_case. Prefix k for variable names that start with a number (e.g., k_99th_percentile).
Python global variables should use upper snake_case and prefix G (e.g., G_MY_GLOBAL).
Python constants should use upper snake_case (e.g., MY_CONSTANT).
Avoid shadowing variables declared in an outer scope in Python.
Initialize all externally visible members of a Python class in the constructor.
For interfaces that may be used outside a file, prefer docstrings over comments in Python.
Comments in Python should be reserved for code within a function, or interfaces that are local to a file.
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx.
Attributes and variables in Python can be documented inline; attribute docstrings will be rendered under the docstring for the class.
Avoid using reflection in Python when functionality can be easily achieved without reflection.
When using try-except blocks in Python, limit the except to the smallest set of errors possible.
When using try-except blocks to handle multiple possible variable types in Python, keep the body of the try as small as possible, using the else block to implement the logic.

Files:

  • tensorrt_llm/serve/scripts/benchmark_serving.py
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/defs/disaggregated/test_disaggregated.py
**/*.{cpp,h,cu,py}

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code should contain an NVIDIA copyright header that includes the current year. This includes .cpp, .h, .cu, .py, and any other source files which are compiled or interpreted.

Files:

  • tensorrt_llm/serve/scripts/benchmark_serving.py
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/defs/disaggregated/test_disaggregated.py
🧠 Learnings (2)
📓 Common learnings
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
📚 Learning: in tensorrt-llm testing, it's common to have both cli flow tests (test_cli_flow.py) and pytorch api ...
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/qa/llm_sanity_test.txt
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml
  • tests/integration/test_lists/qa/examples_test_list.txt
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/defs/disaggregated/test_disaggregated.py
🧬 Code Graph Analysis (1)
tests/integration/defs/accuracy/test_disaggregated_serving.py (1)
tests/integration/defs/accuracy/accuracy_core.py (4)
  • MMLU (269-283)
  • evaluate (146-199)
  • evaluate (678-688)
  • GSM8K (286-299)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (8)
tests/integration/test_lists/test-db/l0_dgx_b200.yml (1)

73-78: LGTM! Good test coverage for NIXL backend.

The new test entries properly extend the test suite with:

  • Four parameterized benchmark tests covering different model configurations (DeepSeek-V3-Lite with bf16/fp8, llama models)
  • Two accuracy tests validating NIXL backend functionality

This aligns well with the PR objective to verify NIXL backend performance parity with UCX.

tests/integration/test_lists/test-db/l0_dgx_h100.yml (2)

53-54: LGTM! Consistent NIXL backend test additions.

The accuracy tests for NIXL backend are properly added to the PyTorch backend pre_merge stage.


111-114: LGTM! Benchmark tests properly added to deepseek trigger section.

The four parameterized benchmark tests are appropriately placed under the deepseek auto_trigger condition, maintaining consistency with the B200 configuration.

tests/integration/defs/accuracy/test_disaggregated_serving.py (2)

262-283: LGTM! Test properly validates NIXL backend with accuracy tasks.

The test correctly:

  • Configures both context and generation servers to use the "nixl" backend
  • Launches the disaggregated LLM with appropriate configuration
  • Runs both MMLU and GSM8K evaluation tasks to verify accuracy

This provides comprehensive validation of the NIXL backend functionality.


481-504: LGTM! Test configuration appropriate for DeepSeek model.

The test properly uses tensor_parallel_size=4 which is appropriate for the DeepSeek-V3-Lite model requirements. The test structure follows the same pattern as the Llama test, ensuring consistency.

tests/integration/defs/disaggregated/test_disaggregated.py (3)

30-33: LGTM! Cleanup properly extended for new config files.

The cleanup function now removes the UCX and NIXL config files created during benchmark tests.


1061-1090: LGTM! Well-structured fixtures for benchmarking.

The fixtures properly:

  • Locate benchmark scripts and datasets
  • Map model names to their paths with support for multiple model variants
  • Follow the existing fixture patterns in the codebase

1206-1249: Well-implemented benchmark comparison test.

The test effectively:

  • Covers multiple model configurations through parameterization
  • Creates appropriate config files for both backends
  • Runs benchmarks and compares performance metrics
  • Uses a reasonable 5% tolerance for performance parity validation

This provides comprehensive validation that NIXL backend achieves comparable performance to UCX as intended.

@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 5, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14125 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14121 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14125 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10656 completed with status: 'FAILURE'

@bo-nv bo-nv force-pushed the user/bo/add-more-nixl-tests branch from c73f67d to 2b696f6 Compare August 6, 2025 00:35
@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 6, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14196 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14196 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10721 completed with status: 'FAILURE'

@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 6, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14204 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14204 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10728 completed with status: 'FAILURE'

@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 6, 2025

/bot run --add-multi-gpu-test

1 similar comment
@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 6, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14257 [ run ] triggered by Bot

@bo-nv bo-nv force-pushed the user/bo/add-more-nixl-tests branch from 2b696f6 to f7345bf Compare August 6, 2025 10:00
@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 6, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14295 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14257 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14295 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10798 completed with status: 'FAILURE'

@bo-nv bo-nv force-pushed the user/bo/add-more-nixl-tests branch from 18c2bba to 078cd12 Compare August 7, 2025 03:09
@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 7, 2025

/bot run --add-multi-gpu-test

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (2)
tests/integration/defs/disaggregated/test_disaggregated.py (2)

1176-1185: Consider more robust metric parsing.

The regex patterns assume a specific output format. Consider adding error handling for unexpected formats or logging the full output on parsing failure for debugging.


1279-1280: Improve assertion messages for better debugging.

The assertions should provide more context when they fail to help with debugging performance regressions.

🧹 Nitpick comments (1)
tests/integration/defs/disaggregated/test_disaggregated.py (1)

1100-1100: Consider making number of ranks configurable.

The hard-coded num_rank = 2 could be made configurable through a parameter to support different test configurations.

-def run_disaggregated_benchmark(example_dir,
-                                config_file,
-                                benchmark_root,
-                                benchmark_model_root,
-                                shared_gpt_path,
-                                env=None,
-                                cwd=None):
+def run_disaggregated_benchmark(example_dir,
+                                config_file,
+                                benchmark_root,
+                                benchmark_model_root,
+                                shared_gpt_path,
+                                env=None,
+                                cwd=None,
+                                num_ranks=2):
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18c2bba and e575080.

📒 Files selected for processing (7)
  • tensorrt_llm/serve/scripts/benchmark_serving.py (1 hunks)
  • tests/integration/defs/accuracy/test_disaggregated_serving.py (2 hunks)
  • tests/integration/defs/disaggregated/test_disaggregated.py (2 hunks)
  • tests/integration/test_lists/qa/llm_function_full.txt (1 hunks)
  • tests/integration/test_lists/qa/llm_function_sanity.txt (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • tests/integration/test_lists/qa/llm_function_full.txt
  • tests/integration/test_lists/qa/llm_function_sanity.txt
🚧 Files skipped from review as they are similar to previous changes (4)
  • tensorrt_llm/serve/scripts/benchmark_serving.py
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

**/*.py: Python code should conform to Python 3.8+.
Indent Python code with 4 spaces. Do not use tabs.
Always maintain the namespace when importing in Python, even if only one class or function from a module is used.
Python filenames should use snake_case (e.g., some_file.py).
Python classes should use PascalCase (e.g., class SomeClass).
Python functions and methods should use snake_case (e.g., def my_awesome_function():).
Python local variables should use snake_case. Prefix k for variable names that start with a number (e.g., k_99th_percentile).
Python global variables should use upper snake_case and prefix G (e.g., G_MY_GLOBAL).
Python constants should use upper snake_case (e.g., MY_CONSTANT).
Avoid shadowing variables declared in an outer scope in Python.
Initialize all externally visible members of a Python class in the constructor.
For interfaces that may be used outside a Python file, prefer docstrings over comments.
Comments in Python should be reserved for code within a function, or interfaces that are local to a file.
Use Google style docstrings for Python classes and functions, which can be parsed by Sphinx.
Attributes and variables in Python can be documented inline; attribute docstrings will be rendered under the class docstring.
Avoid using reflection in Python when functionality can be easily achieved without it.
When using try-except blocks in Python, limit the except to the smallest set of errors possible.
When using try-except blocks to handle multiple possible variable types in Python, keep the body of the try as small as possible, using the else block to implement the logic.

Files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
**/*.{cpp,h,hpp,cc,cxx,cu,py}

📄 CodeRabbit Inference Engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code should contain an NVIDIA copyright header that includes the current year. This includes .cpp, .h, .cu, .py, and any other source files which are compiled or interpreted.

Files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
🧠 Learnings (3)
📓 Common learnings
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
📚 Learning: in tensorrt-llm testing, it's common to have both cli flow tests (test_cli_flow.py) and pytorch api ...
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
📚 Learning: in tensorrt-llm, test files (files under tests/ directories) do not require nvidia copyright headers...
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.

Applied to files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (6)
tests/integration/defs/disaggregated/test_disaggregated.py (6)

17-17: LGTM on new imports.

The new imports (re, tempfile, yaml) and additional test utilities are appropriate for the benchmarking functionality being added.

Also applies to: 19-19, 22-24


1059-1087: Well-structured fixtures for benchmarking.

The fixtures properly scope resources and handle parameterization. The error handling in benchmark_model_root is appropriate for invalid model parameters.


1187-1202: Excellent error handling with detailed logging.

The exception handling properly logs both worker and server outputs, which will be valuable for debugging benchmark failures.


1204-1238: Clean configuration generation function.

The function properly parameterizes the backend and provides appropriate defaults for benchmarking scenarios.


1241-1257: Well-structured parameterized benchmark test.

The test properly handles multiple model configurations and creates temporary config files for different backends.


1276-1278: Good performance metrics logging.

The print statements provide useful visibility into the benchmark results for both backends.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14367 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14367 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10858 completed with status: 'FAILURE'

@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 7, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14383 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14383 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10873 completed with status: 'FAILURE'

@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 7, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14401 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14401 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10885 completed with status: 'FAILURE'

@pcastonguay
Copy link
Collaborator

@bo-nv could we update the PR to target release/1.0 branch?

@bo-nv bo-nv force-pushed the user/bo/add-more-nixl-tests branch from e575080 to b53bafa Compare August 7, 2025 16:41
@bo-nv bo-nv requested a review from a team as a code owner August 7, 2025 16:41
@bo-nv bo-nv requested a review from chzblych August 7, 2025 16:41
@bo-nv bo-nv changed the base branch from main to release/1.0 August 7, 2025 16:42
@bo-nv
Copy link
Collaborator Author

bo-nv commented Aug 7, 2025

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14496 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #14496 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #17 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@Shixiaowei02 Shixiaowei02 enabled auto-merge (squash) August 8, 2025 02:10
@Shixiaowei02 Shixiaowei02 merged commit d289d85 into NVIDIA:release/1.0 Aug 8, 2025
4 checks passed
@bo-nv bo-nv deleted the user/bo/add-more-nixl-tests branch August 8, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants