Skip to content

Conversation

lucaslie
Copy link
Member

Better clean-up of process groups to avoid warnings at the end of pipeline

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie lucaslie self-assigned this May 15, 2025
@lucaslie lucaslie added the AutoDeploy <NV> AutoDeploy Backend label May 15, 2025
@lucaslie
Copy link
Member Author

/bot run

@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board May 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Improve distributed process group cleanup to prevent end-of-pipeline warnings.

  • Introduce a centralized cleanup() function in common.py.
  • Register cleanup() on program exit and invoke it in init/finally and stop handlers.
  • Add a destructor in demollm.py to shut down executors and call cleanup().

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tensorrt_llm/_torch/auto_deploy/shim/demollm.py Added __del__ to shut down executor and invoke dist_ad.cleanup
tensorrt_llm/_torch/auto_deploy/distributed/common.py Added cleanup(), registered it with atexit, and invoked on exit and stop finalization
Comments suppressed due to low confidence (1)

tensorrt_llm/_torch/auto_deploy/distributed/common.py:147

  • Missing import for 'atexit'—this will cause a NameError at runtime. Add import atexit at the top of the module.
atexit.register(cleanup)

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5416 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5416 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3953 completed with status: 'SUCCESS'

@suyoggupta
Copy link
Collaborator

nice

@lucaslie lucaslie merged commit 0e872ef into NVIDIA:main May 16, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoDeploy <NV> AutoDeploy Backend

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants