Skip to content

Conversation

shaharmor98
Copy link
Collaborator

@shaharmor98 shaharmor98 commented May 9, 2025

PR title

Description

This PR includes the changes required for feature-complete support of LoRA in PyTorch flow.
It includes:

  • API changes
  • FP8 test
  • Nemotron-NAS dummy support

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@shaharmor98 shaharmor98 requested review from a team as code owners May 9, 2025 07:38
@shaharmor98
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4680 [ run ] triggered by Bot

@shaharmor98
Copy link
Collaborator Author

/bot kill

@shaharmor98
Copy link
Collaborator Author

/bot run --stage-list="A100X-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4718 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4680 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4718 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 34119f4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4719 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4719 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3404 (Partly Tested) completed with status: 'SUCCESS'

@shaharmor98 shaharmor98 force-pushed the feat/support-torch-lora-fp8-base-model branch from 34119f4 to e0e29d4 Compare May 9, 2025 15:49
@shaharmor98
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4727 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4727 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3411 completed with status: 'FAILURE'

@shaharmor98
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5589 [ run ] triggered by Bot

@shaharmor98
Copy link
Collaborator Author

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5589 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4077 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5590 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5590 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit a06bdc3

@shaharmor98
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5591 [ run ] triggered by Bot

@shaharmor98
Copy link
Collaborator Author

/bot kill

@shaharmor98
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5593 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5591 [ run ] completed with state ABORTED
/LLM/main/L0_MergeRequest_PR pipeline #4078 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5593 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 5a54bfe

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5594 [ run ] triggered by Bot

@shaharmor98
Copy link
Collaborator Author

/bot kill

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5604 [ kill ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5594 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5604 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 1245235

@shaharmor98 shaharmor98 force-pushed the feat/support-torch-lora-fp8-base-model branch from 1245235 to 0355c80 Compare May 18, 2025 08:43
@shaharmor98
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5605 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5606 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5605 [ run ] completed with state ABORTED

@shaharmor98
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5609 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5606 [ run ] completed with state ABORTED

@shaharmor98 shaharmor98 enabled auto-merge (squash) May 18, 2025 12:29
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5609 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4094 completed with status: 'SUCCESS'

@shaharmor98 shaharmor98 merged commit 27afcb9 into NVIDIA:main May 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants