Skip to content

Conversation

venkywonka
Copy link
Collaborator

PR title

Enable option in trtllm-bench build subcommand to avoid loading weights.

  • Although measuring perf numbers with dummy weights is not recommended, for some cases when we just want to pipeclean or debug orthogonal parts with trtllm-bench build subcommand being the entry-point, we don't want to waste time waiting for the safetensors to load to memory (that's probably irrelevant to our objective).
  • This shaves off several minutes of iterations - something like ~7 minutes on a 253B model by avoiding all those shards.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@venkywonka venkywonka marked this pull request as ready for review May 8, 2025 03:59
@venkywonka venkywonka requested review from FrankD412 and Copilot May 8, 2025 03:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CLI option to the trtllm-bench build subcommand that allows users to bypass loading actual checkpoint weights in favor of dummy weights for performance and debugging purposes.

  • Introduces a new option (--no_weights_loading) to control whether weights are loaded.
  • Sets a new "load_format" based on that option, and passes it to the engine-building function.

@venkywonka venkywonka self-assigned this May 8, 2025
@venkywonka
Copy link
Collaborator Author

@kaiyux @LarryXFly can I get an approval for merge?

@venkywonka venkywonka force-pushed the user/venky/bench-build-expose-dummy-loading branch from dce2e94 to 210e1f2 Compare May 13, 2025 01:53
@venkywonka
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4927 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #4927 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3575 completed with status: 'FAILURE'

@venkywonka venkywonka force-pushed the user/venky/bench-build-expose-dummy-loading branch from 210e1f2 to 2296855 Compare May 13, 2025 12:39
@venkywonka venkywonka requested review from chzblych and kaiyux May 14, 2025 03:12
@venkywonka
Copy link
Collaborator Author

@chzblych / @kaiyux please to review and unblock this PR

@venkywonka venkywonka force-pushed the user/venky/bench-build-expose-dummy-loading branch from 2296855 to efd230a Compare May 14, 2025 23:13
@venkywonka
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5218 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5218 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3810 completed with status: 'FAILURE'

Signed-off-by: Venky <[email protected]>
Signed-off-by: Venky <[email protected]>
@venkywonka venkywonka force-pushed the user/venky/bench-build-expose-dummy-loading branch from efd230a to cb3b6f7 Compare May 15, 2025 13:10
@venkywonka
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5349 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5349 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3902 completed with status: 'SUCCESS'

@FrankD412
Copy link
Collaborator

/bot reuse-pipeline

@FrankD412 FrankD412 enabled auto-merge (squash) May 15, 2025 19:17
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5398 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5398 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #5349 for commit 20fde05

@FrankD412 FrankD412 merged commit 5ebe32f into NVIDIA:main May 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants