-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[fix] trtllm-gen mla kernel warnings #4119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/bot run |
PR_Github #4368 [ run ] triggered by Bot |
PR_Github #4368 [ run ] completed with state |
/bot run |
PR_Github #4380 [ run ] triggered by Bot |
PR_Github #4380 [ run ] completed with state |
/bot run |
PR_Github #4393 [ run ] triggered by Bot |
PR_Github #4393 [ run ] completed with state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could solve the problem. But the better solution is that fmhaDispatcher should not be used when trtllmGen is enabled.
The code path of AttentionOp has been a bit messy (fmha/trtllm-gen/flashmla), especially with the introduction of MLA. Let's see if we can have an opportunity to refactor.
9aec810
to
4c799c5
Compare
/bot run |
PR_Github #4488 [ run ] triggered by Bot |
PR_Github #4488 [ run ] completed with state |
4c799c5
to
c6a7fe1
Compare
/bot run |
PR_Github #4528 [ run ] triggered by Bot |
PR_Github #4528 [ run ] completed with state |
c6a7fe1
to
bc68d82
Compare
/bot run |
PR_Github #4623 [ run ] triggered by Bot |
PR_Github #4623 [ run ] completed with state |
Signed-off-by: Zhen Huang <[email protected]>
bc68d82
to
db11a37
Compare
/bot run |
PR_Github #4660 [ run ] triggered by Bot |
PR_Github #4660 [ run ] completed with state |
[fix] trtllm-gen mla kernel warnings
Description
We have some warnings like these when running MLA on SM100:
The warnings are introduced by #3862. This PR aims to fix them by always modifying fmhaParams no matter mIsGenerationMLA is true or false.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]
Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.